Differential D8632

nixguix: Refactor by renaming success or failure the different datasets
ClosedPublic
Actions

Authored by ardumont on Oct 5 2022, 4:51 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T3781: Replace the Nixguix loader with a lister

Commits

rDLS5a53243bd3de: nixguix: Refactor by renaming success or failure the different datasets

Summary

It's more explicit that way.

Related to T3781

Diff Detail

Repository

rDLS Listers

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 32127
Build 50303: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 50302: arc lint + arc unit

Event Timeline

ardumont created this revision.Oct 5 2022, 4:51 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 5 2022, 4:51 PM

ardumont mentioned this in D8631: nixguix: Deal with manifest entries without an integrity field.Oct 5 2022, 4:52 PM

Build is green

Patch application report for D8632 (id=31169)

Rebasing onto 2e6e282d44...

Current branch diff-target is up to date.

Changes applied before test

commit 5959ba656f18e602ec548d50989de46774635695
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 5 16:51:01 2022 +0200

    nixguix: Refactor by renaming success or failure the different datasets
    
    It's more explicit that way.
    
    Related to T3781

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/765/ for more details.

Harbormaster completed remote builds in B32127: Diff 31169.Oct 5 2022, 4:57 PM

ardumont requested review of this revision.Oct 5 2022, 4:57 PM

Rebase

Build is green

Patch application report for D8632 (id=31175)

Rebasing onto 4a09f660b3...

Current branch diff-target is up to date.

Changes applied before test

commit 5a53243bd3de08988703fcad7a0083d6031fd9e0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Oct 5 16:51:01 2022 +0200

    nixguix: Refactor by renaming success or failure the different datasets
    
    It's more explicit that way.
    
    Related to T3781

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/767/ for more details.

Harbormaster completed remote builds in B32133: Diff 31175.Oct 5 2022, 11:02 PM

anlambert accepted this revision.Oct 6 2022, 10:38 AM

This revision is now accepted and ready to land.Oct 6 2022, 10:38 AM

Closed by commit rDLS5a53243bd3de: nixguix: Refactor by renaming success or failure the different datasets (authored by ardumont). · Explain WhyOct 6 2022, 10:52 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLS5a53243bd3de: nixguix: Refactor by renaming success or failure the different datasets.