Page MenuHomeSoftware Heritage

test: Deduplicate tests implementation for loader tasks creation
ClosedPublic

Authored by anlambert on Oct 4 2022, 4:07 PM.

Details

Summary

Add a dedicated fixture implementing loader task creation check for
a given lister and listed origin and use it in tasks tests for
available loaders.

Also remove redundant tests performing the same checks as that
new fixture.

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Branch
deduplicate-task-tests-code
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 32078
Build 50224: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 50223: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D8613 (id=31108)

Rebasing onto a5255f1064...

Current branch diff-target is up to date.
Changes applied before test
commit b26b98810d54134c8d4b810a835e980efa02cd2e
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 4 16:03:06 2022 +0200

    test: Deduplicate tests implementation for loader tasks creation
    
    Add a dedicated fixture implementing loader task creation check for
    a given lister and listed origin and use it in tasks tests for
    available loaders.
    
    Also remove redundant tests performing the same checks as that
    new fixture.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/954/ for more details.

This revision is now accepted and ready to land.Oct 4 2022, 4:14 PM