Page MenuHomeSoftware Heritage

hashutil: Add sha512 support in MultiHash class
ClosedPublic

Authored by anlambert on Sep 30 2022, 3:00 PM.

Details

Summary

It exists use cases where sha512 checksums need to be computed (content
integrity checks for instances) so add sha512 in the list of hashing
algorithms supported by the MultiHash class.

Diff Detail

Repository
rDMOD Data model
Branch
hashutil-sha512
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 31970
Build 50043: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 50042: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D8586 (id=30999)

Rebasing onto 6a38c4ad04...

Current branch diff-target is up to date.
Changes applied before test
commit 9cd28486e01f58fc317b81f408daa554d168968d
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Sep 30 14:58:21 2022 +0200

    hashutil: Add sha512 support in MultiHash class
    
    It exists use cases where sha512 checksums need to be computed (content
    integrity checks for instances) so add sha512 in the list of hashing
    algorithms supported by the MultiHash class.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/535/ for more details.

ardumont added a subscriber: ardumont.

lgtm

That's also something needed for the ongoing directory/content loader [1]

[1] T3781

This revision is now accepted and ready to land.Sep 30 2022, 3:15 PM

Build is green

Patch application report for D8586 (id=31002)

Rebasing onto 6a38c4ad04...

Current branch diff-target is up to date.
Changes applied before test
commit 9b8beef15819e0c05c11750ddbce968ebd93d09b
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Sep 30 14:58:21 2022 +0200

    hashutil: Add sha512 support in MultiHash class
    
    It exists use cases where sha512 checksums need to be computed (content
    integrity checks for instances) so add sha512 in the list of hashing
    algorithms supported by the MultiHash class.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/536/ for more details.