Differential D8537

browse: Add 'Save again' button in origin visits view
ClosedPublic
Actions

Authored by anlambert on Sep 26 2022, 5:17 PM.

Details

Reviewers

jayeshv

Group Reviewers

Reviewers

Maniphest Tasks

T4553: Add “Save code now” to the Visits page

Commits

rDWAPPS4a03dc7bf6af: browse: Add 'Save again' button in origin visits view

Summary

Triggering a new visit from the visits page was previously not
available while it makes sense to have such action here.

Related to T4553

Diff Detail

Repository

rDWAPPS Web applications

Branch

origin-visits-view-add-save-again-button

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 31760
Build 49693: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 49692: arc lint + arc unit

Event Timeline

anlambert created this revision.Sep 26 2022, 5:17 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 26 2022, 5:17 PM

anlambert edited the summary of this revision. (Show Details)Sep 26 2022, 5:17 PM

Build has FAILED

Patch application report for D8537 (id=30783)

Rebasing onto 772928988c...

Current branch diff-target is up to date.

Changes applied before test

commit 4a03dc7bf6af14d02c5e79c099347006e718f6d7
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Sep 26 17:15:39 2022 +0200

    browse: Add 'Save again' button in origin visits view
    
    Triggering a new visit from the visits page was previously not
    available while it makes sense to have such action here.
    
    Related to T4553

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2072/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2072/console

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 26 2022, 5:27 PM

Harbormaster failed remote builds in B31760: Diff 30783!

Build has FAILED

Patch application report for D8537 (id=30783)

Rebasing onto 772928988c...

Current branch diff-target is up to date.

Changes applied before test

commit 4a03dc7bf6af14d02c5e79c099347006e718f6d7
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Sep 26 17:15:39 2022 +0200

    browse: Add 'Save again' button in origin visits view
    
    Triggering a new visit from the visits page was previously not
    available while it makes sense to have such action here.
    
    Related to T4553

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2073/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2073/console

Build is green

Patch application report for D8537 (id=30783)

Rebasing onto 772928988c...

Current branch diff-target is up to date.

Changes applied before test

commit 4a03dc7bf6af14d02c5e79c099347006e718f6d7
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Sep 26 17:15:39 2022 +0200

    browse: Add 'Save again' button in origin visits view
    
    Triggering a new visit from the visits page was previously not
    available while it makes sense to have such action here.
    
    Related to T4553

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2074/ for more details.

Harbormaster completed remote builds in B31760: Diff 30783.Sep 27 2022, 11:43 AM

anlambert requested review of this revision.Sep 27 2022, 11:43 AM

jayeshv accepted this revision.Sep 27 2022, 11:45 AM

This revision is now accepted and ready to land.Sep 27 2022, 11:45 AM

Closed by commit rDWAPPS4a03dc7bf6af: browse: Add 'Save again' button in origin visits view (authored by anlambert). · Explain WhySep 27 2022, 11:50 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS4a03dc7bf6af: browse: Add 'Save again' button in origin visits view.