Related T1718
Details
Details
- Reviewers
vlorentz anlambert - Group Reviewers
Reviewers - Maniphest Tasks
- T1718: Implement a NuGet(.NET) lister
- Commits
- rDLS3928fc9ee9ff: Nuget: Lister for NuGet the package manager for .NET
Diff Detail
Diff Detail
- Repository
- rDLS Listers
- Branch
- nuget
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 31727 Build 49644: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 49643: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D8528 (id=30731)
Rebasing onto 9b3e565cf7...
Current branch diff-target is up to date.
Changes applied before test
commit 8a9b6a37b476607f52cc7deac6db8a033c09298f
Author: Franck Bret <franck.bret@octobus.net>
Date: Fri Sep 23 17:39:55 2022 +0200
[WIP] Nuget: Lister for NuGet the package manager for .NET
Related T1718See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/681/ for more details.
Comment Actions
Build is green
Patch application report for D8528 (id=30750)
Rebasing onto d5c30a3ce3...
Current branch diff-target is up to date.
Changes applied before test
commit 895be2af9c284a2d5ddb9bf460d982e56116d141
Author: Franck Bret <franck.bret@octobus.net>
Date: Fri Sep 23 17:39:55 2022 +0200
Nuget: Lister for NuGet the package manager for .NET
Related T1718See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/691/ for more details.
Comment Actions
Build is green
Patch application report for D8528 (id=30773)
Rebasing onto fd1a4244a0...
Current branch diff-target is up to date.
Changes applied before test
commit 1c4031fcda84b937f7bcff30d90ec93585cdfa67
Author: Franck Bret <franck.bret@octobus.net>
Date: Fri Sep 23 17:39:55 2022 +0200
Nuget: Lister for NuGet the package manager for .NET
Related T1718See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/695/ for more details.
Comment Actions
More complete tests and basic documentation
Add .nuspec fixture that contains 'repository' entry which is used as origin url
Add basic documentation about how the lister work
Comment Actions
Build is green
Patch application report for D8528 (id=30781)
Rebasing onto fd1a4244a0...
Current branch diff-target is up to date.
Changes applied before test
commit 50d1293fae37a4aa99c072db38b9d7f6e0f8afc8
Author: Franck Bret <franck.bret@octobus.net>
Date: Fri Sep 23 17:39:55 2022 +0200
Nuget: Lister for NuGet the package manager for .NET
Related T1718See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/697/ for more details.
| swh/lister/nuget/lister.py | ||
|---|---|---|
| 123–126 | The api endpoint to download package manifest When looking at it with @anlambert we discover that the linked archives did contains binary, not real source code. I've send an email to support to be sure, no answer for now. | |
| 128 | nice catch, it wasn't that directly that end to have origins in tests, but the fact that those ones does not have a 'repository' entry in their nuspec file. | |
Comment Actions
Overall looks good to me, just a couple of inline comments to handle.
| swh/lister/nuget/__init__.py | ||
|---|---|---|
| 52 | Use compose v2 command instead: docker compose up -d | |
| 54–60 | Then schedule a nuget listing task:: docker compose exec swh-scheduler swh scheduler task add -p oneshot list-nuget You can follow lister execution by displaying logs of swh-lister service:: docker compose logs -f swh-lister | |
| swh/lister/nuget/lister.py | ||
| 23–26 | You can remove the user-agent setting code, it is now handled in base lister class. | |
| 33 | Could be svn or hg too, better not setting a visit type here. | |
| 62 | You can remove the params parameter here. | |
| 69 | ditto | |
| 93 | ditto | |
| 108 | ditto | |
| 115–116 | You can merge this two lines into a single one. | |
| swh/lister/nuget/tests/test_lister.py | ||
| 4 | Please add a new line between license header and imports. | |
Comment Actions
Build is green
Patch application report for D8528 (id=30784)
Rebasing onto fd1a4244a0...
Current branch diff-target is up to date.
Changes applied before test
commit db3633769b9d5be4d72763163a4f9492c4b41962
Author: Franck Bret <franck.bret@octobus.net>
Date: Fri Sep 23 17:39:55 2022 +0200
Nuget: Lister for NuGet the package manager for .NET
Related T1718See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/699/ for more details.
| swh/lister/nuget/__init__.py | ||
|---|---|---|
| 11–13 | now that I understand the lister better; could you mention it prominently here that the lister discovers origins on other forges because NuGet packages are binaries? (I know "Origins from page" says it already, but it's pretty important) | |
Comment Actions
Explain that the lister discovers origins on other forges because NuGet packages are binaries
Comment Actions
Build is green
Patch application report for D8528 (id=30831)
Rebasing onto cd596eb2b4...
Current branch diff-target is up to date.
Changes applied before test
commit 3928fc9ee9ff98497b3a2e7151c72f42850fe799
Author: Franck Bret <franck.bret@octobus.net>
Date: Fri Sep 23 17:39:55 2022 +0200
Nuget: Lister for NuGet the package manager for .NET
Related T1718See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/710/ for more details.
Comment Actions
Build is green
Patch application report for D8528 (id=30847)
Rebasing onto cd596eb2b4...
Current branch diff-target is up to date.
Changes applied before test
commit 3928fc9ee9ff98497b3a2e7151c72f42850fe799
Author: Franck Bret <franck.bret@octobus.net>
Date: Fri Sep 23 17:39:55 2022 +0200
Nuget: Lister for NuGet the package manager for .NET
Related T1718See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/712/ for more details.