Page MenuHomeSoftware Heritage

package/tests: Add a visit success test for StubPackageLoader
ClosedPublic

Authored by anlambert on Mon, Sep 19, 4:41 PM.

Details

Summary

Such test was missing so add a couple of tiny tarballs in tests
data directory and simulate a successful visit for origin example.

Also update origin URL and remove a couple of hardcoded litterals.

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D8503 (id=30626)

Rebasing onto 0c599bdc81...

Current branch diff-target is up to date.
Changes applied before test
commit 99e56d3f8746cf38c90e3e658e8937018c08a57a
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Sep 19 15:29:12 2022 +0200

    package/tests: Add a visit success test for StubPackageLoader
    
    Such test was missing so add a couple of tiny tarballs in tests
    data directory and simulate a successful visit for origin example.
    
    Also update origin URL and remove a couple of hardcoded litterals.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/875/ for more details.

ardumont added a subscriber: ardumont.
ardumont added inline comments.
swh/loader/package/tests/test_loader.py
118

what about?

This revision is now accepted and ready to land.Tue, Sep 20, 11:45 AM
swh/loader/package/tests/test_loader.py
118

Better indeed, thanks !

Build is green

Patch application report for D8503 (id=30635)

Rebasing onto c4370009d0...

Current branch diff-target is up to date.
Changes applied before test
commit 63ccbd9a3a671a4b218529be7d12d2fb1542b5cd
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Sep 19 15:29:12 2022 +0200

    package/tests: Add a visit success test for StubPackageLoader
    
    Such test was missing so add a couple of tiny tarballs in tests
    data directory and simulate a successful visit for origin example.
    
    Also update origin URL and remove a couple of hardcoded litterals.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/880/ for more details.