Page MenuHomeSoftware Heritage
Differential D8496

golang: Ensure to case-encode URLs for retrieving package info
ClosedPublic
Actions

Authored by anlambert on Sep 16 2022, 1:49 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDLDBASE0c599bdc81e3: golang: Ensure to case-encode URLs for retrieving package info
Summary

When a go package name contains uppercase characters in it, associated
goproxy URLs need to be case-encoded by replacing every uppercase letter
with an exclamation mark followed by the corresponding lower-case letter.

This fixes the loading of such packages.

See https://go.dev/ref/mod#goproxy-protocol.

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Sep 16 2022, 1:49 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptSep 16 2022, 1:49 PM
swh-public-ci added a comment.Sep 16 2022, 1:52 PM

Build is green

Patch application report for D8496 (id=30592)

Rebasing onto 134087342b...

Current branch diff-target is up to date.
Changes applied before test
commit b453eb288eb8af5c7d82e108ba4993c7ba7e2bd3
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Sep 16 13:45:13 2022 +0200

    golang: Ensure to case-encode URLs for retrieving package info
    
    When a go package name contains uppercase characters in it, associated
    goproxy URLs need to be case-encoded by replacing every uppercase letter
    with an exclamation mark followed by the corresponding lower-case letter.
    
    This fixes the loading of such packages.
    
    See https://go.dev/ref/mod#goproxy-protocol.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/871/ for more details.

Harbormaster completed remote builds in B31584: Diff 30592.Sep 16 2022, 1:52 PM
anlambert requested review of this revision.Sep 16 2022, 1:52 PM
vlorentz accepted this revision.Sep 18 2022, 2:09 PM
This revision is now accepted and ready to land.Sep 18 2022, 2:09 PM
anlambert updated this revision to Diff 30608.Sep 19 2022, 10:52 AM

Rebase and update commit message

swh-public-ci added a comment.Sep 19 2022, 10:55 AM

Build is green

Patch application report for D8496 (id=30608)

Rebasing onto 134087342b...

Current branch diff-target is up to date.
Changes applied before test
commit 0c599bdc81e3f8482ae4e3103824df7e3f19b930
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Sep 16 13:45:13 2022 +0200

    golang: Ensure to case-encode URLs for retrieving package info
    
    When a go package name contains uppercase characters in it, associated
    goproxy URLs need to be case-encoded by replacing every uppercase letter
    with an exclamation mark followed by the corresponding lower-case letter.
    
    This fixes the loading of such packages.
    
    See https://go.dev/ref/mod#goproxy-protocol.
    
    Related to T4124

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/873/ for more details.

Harbormaster completed remote builds in B31593: Diff 30608.Sep 19 2022, 10:56 AM
Closed by commit rDLDBASE0c599bdc81e3: golang: Ensure to case-encode URLs for retrieving package info (authored by anlambert). · Explain WhySep 19 2022, 10:57 AM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDLDBASE0c599bdc81e3: golang: Ensure to case-encode URLs for retrieving package info.

Revision Contents
Changeset List

Diff 30611

View Options

swh/loader/package/golang/loader.py

Loading...
View Options

swh/loader/package/golang/tests/data/https_proxy.golang.org/github.com_adam-hanna_array!operations_@latest

Loading...
View Options

swh/loader/package/golang/tests/data/https_proxy.golang.org/github.com_adam-hanna_array!operations_@v_list

Loading...
View Options

swh/loader/package/golang/tests/data/https_proxy.golang.org/github.com_adam-hanna_array!operations_@v_v1.0.1.info

Loading...
View Options

swh/loader/package/golang/tests/data/https_proxy.golang.org/github.com_adam-hanna_array!operations_@v_v1.0.1.zip

Loading...
View Options

swh/loader/package/golang/tests/test_golang.py

Loading...
About · Developer information · Legal