Add a 'swh graph grpc-serve' command
ClosedPublic
Actions

Authored by douardda on Sep 13 2022, 3:02 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDGRPH99a97d7ebaf2: Add a 'swh graph grpc-serve' command

Summary

that start the java GRPC server only.

Diff Detail

Repository

rDGRPH Compressed graph representation

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Sep 13 2022, 3:02 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 13 2022, 3:02 PM

Build is green

Patch application report for D8464 (id=30493)

Rebasing onto f294538188...

Current branch diff-target is up to date.

Changes applied before test

commit 61871422d99f01ff2637e5a3adbb36480e124c39
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Sep 13 14:59:53 2022 +0200

    Add a 'swh graph grpc-serve' command
    
    that start the java GRPC server only.

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/237/ for more details.

Harbormaster completed remote builds in B31500: Diff 30493.Sep 13 2022, 3:14 PM

douardda requested review of this revision.Sep 13 2022, 3:14 PM

olasd requested changes to this revision.Sep 13 2022, 3:44 PM

olasd added a subscriber: olasd.

olasd added inline comments.

swh/graph/cli.py
149–155	Probably worth using the commonly used `JAVA_HOME` envvar rather than an ad-hoc `JAVABIN`.
176–177	Probably should use `shutil.which` instead (prepending `JAVA_HOME/bin` to the PATH if needed)
180	`os.execve` takes 3 args; should use `execv` instead (if not changing the environment)

This revision now requires changes to proceed.Sep 13 2022, 3:44 PM

douardda marked 3 inline comments as done.Sep 13 2022, 4:00 PM

apply olasd's suggestions

Build is green

Patch application report for D8464 (id=30498)

Rebasing onto f294538188...

Current branch diff-target is up to date.

Changes applied before test

commit 99a97d7ebaf276e1dbc702a83d5b729004e9eb2e
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Sep 13 14:59:53 2022 +0200

    Add a 'swh graph grpc-serve' command
    
    that start the java GRPC server only.

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/238/ for more details.

Harbormaster completed remote builds in B31505: Diff 30498.Sep 13 2022, 4:10 PM

olasd accepted this revision.Sep 13 2022, 4:29 PM

This revision is now accepted and ready to land.Sep 13 2022, 4:29 PM

Closed by commit rDGRPH99a97d7ebaf2: Add a 'swh graph grpc-serve' command (authored by douardda). · Explain WhySep 13 2022, 4:32 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDGRPH99a97d7ebaf2: Add a 'swh graph grpc-serve' command.