Page MenuHomeSoftware Heritage
Differential D8457

Add type hints to archive and search modules
ClosedPublic
Actions

Authored by jayeshv on Sep 13 2022, 11:09 AM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Maniphest Tasks
T4261: Swh-graphql Code cleanup
Commits
rDGQL7e4eacb71f64: Add type hints to archive and search modules
Summary

Related to T4261

Diff Detail

Repository
rDGQL GraphQL API
Branch
types
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 31486
Build 49254: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 49253: arc lint + arc unit

Event Timeline

jayeshv created this revision.Sep 13 2022, 11:09 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptSep 13 2022, 11:09 AM
swh-public-ci added a comment.Sep 13 2022, 11:12 AM

Build is green

Patch application report for D8457 (id=30479)

Rebasing onto 2c3b16f795...

Current branch diff-target is up to date.
Changes applied before test
commit 7e4eacb71f640106f669b5d4b3093d73fc1a1c00
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Sep 12 10:37:08 2022 +0200

    Add type hints to archive and search modules
    
    Related to T4261

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/172/ for more details.

Harbormaster completed remote builds in B31486: Diff 30479.Sep 13 2022, 11:12 AM
jayeshv requested review of this revision.Sep 13 2022, 11:12 AM
anlambert accepted this revision.Sep 13 2022, 11:14 AM
anlambert added a subscriber: anlambert.

Looks good to me.

This revision is now accepted and ready to land.Sep 13 2022, 11:14 AM
Closed by commit rDGQL7e4eacb71f64: Add type hints to archive and search modules (authored by jayeshv). · Explain WhySep 13 2022, 11:20 AM
This revision was automatically updated to reflect the committed changes.
jayeshv added a commit: rDGQL7e4eacb71f64: Add type hints to archive and search modules.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
graphql/
backends/
100 lines97%
Loading...
10 lines100%
Loading...
12 lines46%
Loading...

Diff 30479

View Options

swh/graphql/backends/archive.py

Loading...
View Options

swh/graphql/backends/search.py

Loading...
View Options

swh/graphql/server.py

Loading...
About · Developer information · Legal