Differential D8456

Ignore empty lines from swh-graph instead of crashing
ClosedPublic
Actions

Authored by vlorentz on Sep 13 2022, 10:14 AM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

Restricted Maniphest Task

Commits

rDWAPPS13158c81d2a5: Ignore empty lines from swh-graph instead of crashing

Summary

It happens frequently for some reason, but it does not seem to be
reproducible.

Workaround for T4531. This does not fix the underlying issue, though.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Sep 13 2022, 10:14 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 13 2022, 10:14 AM

vlorentz added a task: Restricted Maniphest Task.Sep 13 2022, 10:14 AM

Build has FAILED

Patch application report for D8456 (id=30475)

Rebasing onto c52158a8d7...

Current branch diff-target is up to date.

Changes applied before test

commit 13158c81d2a5aabe363335f8af4a5f64572b8d0c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 13 10:12:10 2022 +0200

    Ignore empty lines from swh-graph instead of crashing
    
    It happens frequently for some reason, but it does not seem to be
    reproducible.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2048/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2048/console

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 13 2022, 10:23 AM

Harbormaster failed remote builds in B31482: Diff 30475!

vlorentz requested review of this revision.Sep 13 2022, 10:58 AM

anlambert accepted this revision.Sep 13 2022, 10:59 AM

This revision is now accepted and ready to land.Sep 13 2022, 10:59 AM

This revision was landed with ongoing or failed builds.Sep 13 2022, 11:58 AM

Closed by commit rDWAPPS13158c81d2a5: Ignore empty lines from swh-graph instead of crashing (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDWAPPS13158c81d2a5: Ignore empty lines from swh-graph instead of crashing.