Details

Reviewers

douardda

Group Reviewers

Reviewers

Maniphest Tasks

T4522: graph gRPC API: Add support for limiting traversals by number of results

Commits

rDGRPH337269942b12: Add field 'max_matching_nodes' to TraversalRequest

Summary

This allows limiting the number returned by a leaves traversal
request.

Resolves T4522.

Depends on D8547.

Diff Detail

Repository

rDGRPH Compressed graph representation

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 31471
Build 49228: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 49227: arc lint + arc unit

Event Timeline

vlorentz created this revision.Sep 9 2022, 3:41 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 9 2022, 3:41 PM

Build is green

Patch application report for D8438 (id=30417)

Rebasing onto 071271daa4...

Current branch diff-target is up to date.

Changes applied before test

commit f5605780f717c7de4291a972250dc5c5519762e1
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 9 15:40:39 2022 +0200

    Add field 'max_matching_nodes' to TraversalRequest
    
    This allows limiting the number returned by a leaves traversal
    request.

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/228/ for more details.

Harbormaster completed remote builds in B31434: Diff 30417.Sep 9 2022, 3:50 PM

vlorentz requested review of this revision.Sep 9 2022, 3:50 PM

remove changes not meant to be committed yet

Build was aborted

Patch application report for D8438 (id=30419)

Rebasing onto 071271daa4...

Current branch diff-target is up to date.

Changes applied before test

commit 44f2b1fd38c55139ca59809d51f70e9c488b24b8
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 9 15:53:12 2022 +0200

    Add field 'max_matching_nodes' to TraversalRequest
    
    This allows limiting the number returned by a leaves traversal
    request.

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/229/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/229/console

Harbormaster failed remote builds in B31436: Diff 30419!Sep 9 2022, 4:06 PM

lgtm but would it make sense to test cases with usage of this new option combined with other limiting params ({min,max}_depth and max_edges)?

This revision is now accepted and ready to land.Sep 12 2022, 10:28 AM

It's really hard to test, because results are non-deterministic :/

vlorentz added a child revision: D8447: Add max_matching_nodes parameter to /leaves.Sep 12 2022, 3:17 PM

rebase

Build is green

Patch application report for D8438 (id=30461)

Rebasing onto 7049b584c2...

Current branch diff-target is up to date.

Changes applied before test

commit b54abaddd950b89c66f97177659868397d0bcc68
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 9 15:53:12 2022 +0200

    Add field 'max_matching_nodes' to TraversalRequest
    
    This allows limiting the number returned by a leaves traversal
    request.

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/233/ for more details.

Harbormaster completed remote builds in B31471: Diff 30461.Sep 12 2022, 3:41 PM

rebase

Build has FAILED

Patch application report for D8438 (id=30813)

Rebasing onto a426c1d038...

Current branch diff-target is up to date.

Changes applied before test

commit c9585be99ef981c3c3b0784a88ecd7d4f4a9d614
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 9 15:53:12 2022 +0200

    Add field 'max_matching_nodes' to TraversalRequest
    
    This allows limiting the number returned by a leaves traversal
    request.

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/242/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/242/console

Harbormaster failed remote builds in B31789: Diff 30813!Sep 27 2022, 1:10 PM

rebase

vlorentz edited the summary of this revision. (Show Details)Sep 27 2022, 1:53 PM

Build has FAILED

Patch application report for D8438 (id=30816)

Could not rebase; Attempt merge onto a426c1d038...

Updating a426c1d..3372699
Fast-forward
 java/pom.xml                                       |   6 +
 .../org/softwareheritage/graph/rpc/Traversal.java  |  34 +-
 .../java/org/softwareheritage/graph/GraphTest.java |  29 ++
 .../softwareheritage/graph/rpc/CountEdgesTest.java |  25 ++
 .../softwareheritage/graph/rpc/CountNodesTest.java |  23 +
 .../graph/rpc/TraverseLeavesTest.java              |  43 +-
 proto/swhgraph.proto                               |   3 +
 requirements.txt                                   |   1 +
 swh/graph/grpc/swhgraph_pb2.py                     |  68 +--
 swh/graph/grpc/swhgraph_pb2.pyi                    | 481 +++++++++++----------
 10 files changed, 432 insertions(+), 281 deletions(-)

Changes applied before test

commit 337269942b12c1f8203e1a7e46538436dcd85f5b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 9 15:53:12 2022 +0200

    Add field 'max_matching_nodes' to TraversalRequest
    
    This allows limiting the number returned by a leaves traversal
    request.

commit 76b9820a75aba519c3667765bfa1bc145c55a342
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 27 13:50:34 2022 +0200

    Exclude protobuf 4.21.*
    
    It crashes when swhgraph_pb2.py is discovered by pytest.

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/245/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/245/console

Harbormaster failed remote builds in B31792: Diff 30816!Sep 27 2022, 1:57 PM

vlorentz edited the summary of this revision. (Show Details)Sep 27 2022, 2:00 PM

vlorentz added a parent revision: D8547: Exclude protobuf 4.21.*.

Build is green

Patch application report for D8438 (id=30816)

Could not rebase; Attempt merge onto a426c1d038...

Updating a426c1d..3372699
Fast-forward
 java/pom.xml                                       |   6 +
 .../org/softwareheritage/graph/rpc/Traversal.java  |  34 +-
 .../java/org/softwareheritage/graph/GraphTest.java |  29 ++
 .../softwareheritage/graph/rpc/CountEdgesTest.java |  25 ++
 .../softwareheritage/graph/rpc/CountNodesTest.java |  23 +
 .../graph/rpc/TraverseLeavesTest.java              |  43 +-
 proto/swhgraph.proto                               |   3 +
 requirements.txt                                   |   1 +
 swh/graph/grpc/swhgraph_pb2.py                     |  68 +--
 swh/graph/grpc/swhgraph_pb2.pyi                    | 481 +++++++++++----------
 10 files changed, 432 insertions(+), 281 deletions(-)

Changes applied before test

commit 337269942b12c1f8203e1a7e46538436dcd85f5b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 9 15:53:12 2022 +0200

    Add field 'max_matching_nodes' to TraversalRequest
    
    This allows limiting the number returned by a leaves traversal
    request.

commit 76b9820a75aba519c3667765bfa1bc145c55a342
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 27 13:50:34 2022 +0200

    Exclude protobuf 4.21.*
    
    It crashes when swhgraph_pb2.py is discovered by pytest.

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/247/ for more details.

Harbormaster completed remote builds in B31792: Diff 30816.Sep 27 2022, 2:05 PM

Closed by commit rDGRPH337269942b12: Add field 'max_matching_nodes' to TraversalRequest (authored by vlorentz). · Explain WhySep 27 2022, 3:13 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDGRPH337269942b12: Add field 'max_matching_nodes' to TraversalRequest.

Add field 'max_matching_nodes' to TraversalRequest
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Patch application report for D8438 (id=30417)

Changes applied before test

Patch application report for D8438 (id=30419)

Changes applied before test

Patch application report for D8438 (id=30461)

Changes applied before test

Patch application report for D8438 (id=30813)

Changes applied before test

Patch application report for D8438 (id=30816)

Changes applied before test

Patch application report for D8438 (id=30816)

Changes applied before test

Revision Contents
Changeset List

Diff 30461

java/pom.xml

java/src/main/java/org/softwareheritage/graph/rpc/Traversal.java

java/src/test/java/org/softwareheritage/graph/GraphTest.java

java/src/test/java/org/softwareheritage/graph/rpc/CountEdgesTest.java

java/src/test/java/org/softwareheritage/graph/rpc/CountNodesTest.java

java/src/test/java/org/softwareheritage/graph/rpc/TraverseLeavesTest.java

proto/swhgraph.proto

swh/graph/rpc/swhgraph_pb2.py

swh/graph/rpc/swhgraph_pb2.pyi

Add field 'max_matching_nodes' to TraversalRequestClosedPublicActions

Details

Diff Detail

Event Timeline

Patch application report for D8438 (id=30417)

Changes applied before test

Patch application report for D8438 (id=30419)

Changes applied before test

Patch application report for D8438 (id=30461)

Changes applied before test

Patch application report for D8438 (id=30813)

Changes applied before test

Patch application report for D8438 (id=30816)

Changes applied before test

Patch application report for D8438 (id=30816)

Changes applied before test

Revision ContentsChangeset List

Diff 30461

java/pom.xml

java/src/main/java/org/softwareheritage/graph/rpc/Traversal.java

java/src/test/java/org/softwareheritage/graph/GraphTest.java

java/src/test/java/org/softwareheritage/graph/rpc/CountEdgesTest.java

java/src/test/java/org/softwareheritage/graph/rpc/CountNodesTest.java

java/src/test/java/org/softwareheritage/graph/rpc/TraverseLeavesTest.java

proto/swhgraph.proto

swh/graph/rpc/swhgraph_pb2.py

swh/graph/rpc/swhgraph_pb2.pyi

Add field 'max_matching_nodes' to TraversalRequest
ClosedPublic
Actions

Revision Contents
Changeset List