Page MenuHomeSoftware Heritage

Kill GraphServerProcess on test teardown
ClosedPublic

Authored by vlorentz on Sep 6 2022, 5:06 PM.

Details

Summary

There is no reason to terminate it nicely.

Depends on D8402.

Unit TestsFailed

TimeTest
0 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.graph.tests.test_grpc::test_leaves
@pytest.fixture(scope="module") def graph_grpc_server(): server = GraphServerProcess()
0 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.graph.tests.test_grpc::test_neighbors
@pytest.fixture(scope="module") def graph_grpc_server(): server = GraphServerProcess()
5,580 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.graph.tests.test_grpc::test_stats
@pytest.fixture(scope="module") def graph_grpc_server(): server = GraphServerProcess()
2 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.graph.tests.test_grpc::test_visit_nodes
@pytest.fixture(scope="module") def graph_grpc_server(): server = GraphServerProcess()
0 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.graph.tests.test_grpc::test_visit_nodes_filtered
@pytest.fixture(scope="module") def graph_grpc_server(): server = GraphServerProcess()
View Full Test Results (17 Failed · 13 Passed · 8 Skipped)

Event Timeline

Build has FAILED

Patch application report for D8403 (id=30323)

Could not rebase; Attempt merge onto dd88f177c3...

Updating dd88f17..f2ea86e
Fast-forward
 swh/graph/tests/conftest.py | 38 +++++++++++++++++++-------------------
 1 file changed, 19 insertions(+), 19 deletions(-)
Changes applied before test
commit f2ea86ec523c7ee58301718302dd275034dcf54a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 6 17:06:39 2022 +0200

    Kill GraphServerProcess on test teardown
    
    There is no reason to terminate it nicely.

commit 2104133e41a924cf7d2678ac829b5bee44ba2138
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 6 17:02:22 2022 +0200

    conftest: Refactor GraphServerProcess to be more flexible
    
    1. queue is now encapsulated
    2. object in the queue is now a dict instead of a tuple (to allow
       adding more keys easily in the future + for readability)
    
    This will be used in a future commit, to get the queue's object
    twice from different functions.

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/219/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/219/console

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 6 2022, 5:12 PM
Harbormaster failed remote builds in B31351: Diff 30323!

Build has FAILED

Patch application report for D8403 (id=30326)

Could not rebase; Attempt merge onto dd88f177c3...

Updating dd88f17..8489c14
Fast-forward
 swh/graph/tests/conftest.py | 36 ++++++++++++++++++------------------
 1 file changed, 18 insertions(+), 18 deletions(-)
Changes applied before test
commit 8489c14e20ae3e4a57f3216c282a894cfff236bb
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 6 17:06:39 2022 +0200

    Kill GraphServerProcess on test teardown
    
    There is no reason to terminate it nicely.

commit 46255335308446d7b077099fd9b1c68726faf140
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 6 17:02:22 2022 +0200

    conftest: Refactor GraphServerProcess to be more flexible
    
    1. queue is now encapsulated
    2. object in the queue is now a dict instead of a tuple (to allow
       adding more keys easily in the future + for readability)
    
    This will be used in a future commit, to get the queue's object
    twice from different functions.

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/222/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/222/console

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 6 2022, 5:26 PM
Harbormaster failed remote builds in B31354: Diff 30326!

Build is green

Patch application report for D8403 (id=30330)

Could not rebase; Attempt merge onto dd88f177c3...

Updating dd88f17..4a7f3f7
Fast-forward
 swh/graph/tests/conftest.py | 36 ++++++++++++++++++------------------
 1 file changed, 18 insertions(+), 18 deletions(-)
Changes applied before test
commit 4a7f3f7650a4dd9e29b26b072b019e20115b72b1
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 6 17:06:39 2022 +0200

    Kill GraphServerProcess on test teardown
    
    There is no reason to terminate it nicely.

commit 81d3deb2f1c1b584a076484250cb6f349009f032
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Sep 6 17:02:22 2022 +0200

    conftest: Refactor GraphServerProcess to be more flexible
    
    1. queue is now encapsulated
    2. object in the queue is now a dict instead of a tuple (to allow
       adding more keys easily in the future + for readability)
    
    This will be used in a future commit, to get the queue's object
    twice from different functions.

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/225/ for more details.

olasd added a subscriber: olasd.

Thanks.

This revision is now accepted and ready to land.Sep 6 2022, 5:38 PM