Page MenuHomeSoftware Heritage

webapp/templates/layout: Fix deposit moderation view integration
ClosedPublic

Authored by anlambert on Sep 5 2022, 4:37 PM.

Details

Summary

Test in template file must be splitted in two: one to check if the
swh.web.deposit application is installed, another one to check
user permissions.

An error was raised otherwise when swh.web.deposit is not in
installed application and when admin user logs in.

Related to T4398

Diff Detail

Repository
rDWAPPS Web applications
Branch
deposit-admin-view-integration-fix
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 31322
Build 48999: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 48998: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D8394 (id=30290)

Rebasing onto e96bc074f8...

Current branch diff-target is up to date.
Changes applied before test
commit 32ca92b4a5696b4a2940ba6af0b758ce02730664
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Sep 5 16:33:32 2022 +0200

    webapp/templates/layout: Fix deposit moderation view integration
    
    Test in template file must be splitted in two: one to check if the
    swh.web.deposit application is installed, another one to check
    user permissions.
    
    An error was raised otherwise when swh.web.deposit is not in
    installed application and when admin user logs in.
    
    Related to T4398

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2033/ for more details.

This revision is now accepted and ready to land.Sep 5 2022, 4:51 PM

Build has FAILED

Patch application report for D8394 (id=30294)

Rebasing onto 4df8c0e38c...

Current branch diff-target is up to date.
Changes applied before test
commit 687b4bbddd0505e1759e7308247af26fc7879b36
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Sep 5 16:33:32 2022 +0200

    webapp/templates/layout: Fix deposit moderation view integration
    
    Test in template file must be splitted in two: one to check if the
    swh.web.deposit application is installed, another one to check
    user permissions.
    
    An error was raised otherwise when swh.web.deposit is not in
    installed application and when admin user logs in.
    
    Related to T4398

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2035/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2035/console

This revision was landed with ongoing or failed builds.Sep 5 2022, 5:12 PM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D8394 (id=30294)

Rebasing onto 687b4bbddd...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-2036-D8394.
Changes applied before test

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2036/ for more details.