Rename 'type' field to 'targetType' in the schema
ClosedPublic
Actions

Authored by jayeshv on Sep 5 2022, 2:49 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T4492: GraphQL: rename type fields to targetType for consistency

Commits

rDGQL467e0b7e28bc: Rename 'type' field to 'targetType' in the schema

Summary

'target type' is called 'type' in sanpshot branch, search and directoy entry
objects. This is inconsistent with the field name used in the release object.
Change all the field names representing the type of a target to 'targetType'.

Related to T4492

Diff Detail

Repository

rDGQL GraphQL API

Branch

target-type

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 31314
Build 48986: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 48985: arc lint + arc unit

Event Timeline

jayeshv created this revision.Sep 5 2022, 2:49 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 5 2022, 2:49 PM

Build is green

Patch application report for D8389 (id=30281)

Rebasing onto 6b1c5797f7...

Current branch diff-target is up to date.

Changes applied before test

commit 467e0b7e28bcdf2eb627db01c8268cabb1c42012
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Sep 5 10:06:35 2022 +0200

    Rename 'type' field to 'targetType' in the schema
    
    'target type' is called 'type' in sanpshot branch, search and directoy entry
    objects. This is inconsistent with the field name used in the release object.
    Change all the field names representing the type of a target to 'targetType'.
    
    Related to T4492

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/149/ for more details.

Harbormaster completed remote builds in B31314: Diff 30281.Sep 5 2022, 3:10 PM

jayeshv requested review of this revision.Sep 5 2022, 3:10 PM

anlambert added a subscriber: anlambert.Sep 5 2022, 3:27 PM

anlambert added inline comments.

swh/graphql/schema/schema.graphql
724	The DirectoryEntry model does not name that field `target_type` but simply `type` so I think we should remain aligned with it.

jayeshv added inline comments.Sep 5 2022, 3:38 PM

swh/graphql/schema/schema.graphql
724	Will not that be an inconsistency in the API level? it will be called 'targetType' everywhere and just 'type' here? We can decide either way.

anlambert accepted this revision.Sep 5 2022, 3:44 PM

anlambert added inline comments.

swh/graphql/schema/schema.graphql
724	Yes thinking it back, this looks like a mistake in the model, it should have been renamed to `target_type` for consistency. Looks good to me then.