Page MenuHomeSoftware Heritage

Filter out more invalid URIs that make PyLD crash
ClosedPublic

Authored by vlorentz on Aug 31 2022, 7:58 PM.

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D8373 (id=30215)

Could not rebase; Attempt merge onto 752e5d3f73...

Merge made by the 'recursive' strategy.
 swh/indexer/metadata_dictionary/base.py           | 29 +++++++++-
 swh/indexer/tests/metadata_dictionary/test_npm.py | 67 +++++++++++++++++++++++
 2 files changed, 93 insertions(+), 3 deletions(-)
Changes applied before test
commit 4c0a90569e0ea631c64c5c0eb89035d0cc4713c2
Merge: 752e5d3 92e264d
Author: Jenkins user <jenkins@localhost>
Date:   Wed Aug 31 17:58:41 2022 +0000

    Merge branch 'diff-target' into HEAD

commit 92e264ddec73e80a81aae3b5c1b63ea99a9d390e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Aug 31 19:58:07 2022 +0200

    Filter out more invalid URIs that make PyLD crash

commit ea6862c4d83ba91260aea6c0d8e88ec22a7c9a24
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Aug 31 19:51:25 2022 +0200

    base: Filter out empty URIs so PyLD does not crash

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/473/ for more details.

This revision is now accepted and ready to land.Sep 1 2022, 9:53 AM
This revision was landed with ongoing or failed builds.Sep 1 2022, 12:48 PM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D8373 (id=30225)

Rebasing onto 2ebd7ee876...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-475-D8373.
Changes applied before test

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/475/ for more details.