Differential D8372

base: Filter out empty URIs so PyLD does not crash
ClosedPublic
Actions

Authored by vlorentz on Aug 31 2022, 7:51 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T4459: Deploy swh-indexer > v2.6 on staging then production

Commits

rDCIDX25e709c84a64: base: Filter out empty URIs so PyLD does not crash

Summary

Resolves https://sentry.softwareheritage.org/share/issue/af94bbb7438648239ac9a2f769dc7ec0/

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 31252
Build 48885: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 48884: arc lint + arc unit

Event Timeline

vlorentz created this revision.Aug 31 2022, 7:51 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 31 2022, 7:51 PM

Build is green

Patch application report for D8372 (id=30214)

Rebasing onto 752e5d3f73...

First, rewinding head to replay your work on top of it...
Applying: base: Filter out empty URIs so PyLD does not crash

Changes applied before test

commit 04861853aed5e9c3ebea33993580de6cfba26546
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Aug 31 19:51:25 2022 +0200

    base: Filter out empty URIs so PyLD does not crash

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/472/ for more details.

Harbormaster completed remote builds in B31252: Diff 30214.Aug 31 2022, 8:04 PM

vlorentz requested review of this revision.Aug 31 2022, 8:04 PM

vlorentz added a task: T4459: Deploy swh-indexer > v2.6 on staging then production.Aug 31 2022, 9:14 PM

ardumont accepted this revision.Sep 1 2022, 9:49 AM

ardumont added a subscriber: ardumont.

ardumont added inline comments.

swh/indexer/metadata_dictionary/base.py
285

This revision is now accepted and ready to land.Sep 1 2022, 9:49 AM

rebase

This revision was landed with ongoing or failed builds.Sep 1 2022, 12:48 PM

Closed by commit rDCIDX25e709c84a64: base: Filter out empty URIs so PyLD does not crash (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDCIDX25e709c84a64: base: Filter out empty URIs so PyLD does not crash.

Build is green

Patch application report for D8372 (id=30224)

Rebasing onto 752e5d3f73...

Current branch diff-target is up to date.

Changes applied before test

commit 25e709c84a64dcfe164ca0b1b6bf208d81c28d86
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Aug 31 19:51:25 2022 +0200

    base: Filter out empty URIs so PyLD does not crash

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/474/ for more details.

Harbormaster completed remote builds in B31263: Diff 30224.Sep 1 2022, 12:56 PM