Differential D8352

staging/graphql: Push issues to sentry
ClosedPublic
Actions

Authored by ardumont on Aug 31 2022, 11:14 AM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

System administrators

Maniphest Tasks

T4135: staging: Deploy graphql service

Commits

R260:5aed44119bb7: staging/graphql: Push issues to sentry

Summary

Related to T4135

Diff Detail

Repository

R260 Helm charts for swh packages

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Aug 31 2022, 11:14 AM

Herald added a reviewer: System administrators. · View Herald TranscriptAug 31 2022, 11:14 AM

Harbormaster completed remote builds in B31201: Diff 30157.Aug 31 2022, 11:14 AM

ardumont requested review of this revision.Aug 31 2022, 11:14 AM

Rebase

Harbormaster completed remote builds in B31208: Diff 30164.Aug 31 2022, 11:57 AM

vsellier requested changes to this revision.Aug 31 2022, 3:48 PM

vsellier added a subscriber: vsellier.

vsellier added inline comments.

swh/templates/graphql/deployment.yaml
47	perhaps the whole sentry configuration part should be put inside a if because in an environment without sentry, the secret will still be needed to start the container.

This revision now requires changes to proceed.Aug 31 2022, 3:48 PM

ardumont added inline comments.Aug 31 2022, 3:52 PM

swh/templates/graphql/deployment.yaml
47	Do we really want to allow sentry not being configured?

Add a check prior to activate the sentry configuration

Harbormaster completed remote builds in B31226: Diff 30182.Aug 31 2022, 3:57 PM

vsellier added inline comments.Aug 31 2022, 4:04 PM

swh/templates/graphql/deployment.yaml
47	yes, not everyone or every environment have a sentry (dev / test / mirrors / ...)

ardumont marked 2 inline comments as done.Aug 31 2022, 4:47 PM

vsellier accepted this revision.Aug 31 2022, 4:54 PM

This revision is now accepted and ready to land.Aug 31 2022, 4:54 PM

Closed by commit R260:5aed44119bb7: staging/graphql: Push issues to sentry (authored by ardumont). · Explain WhyAug 31 2022, 4:56 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: R260:5aed44119bb7: staging/graphql: Push issues to sentry.

Revision Contents
Changeset List

Path

Size

swh/

templates/

graphql/

deployment.yaml

13 lines

values/

1 line

Diff 30195

swh/templates/graphql/deployment.yaml

Loading...

swh/values/staging.yaml

Loading...