Differential D8350

Add support for old dicts in RawExtrinsicMetadata.from_dict
ClosedPublic
Actions

Authored by vlorentz on Aug 30 2022, 5:54 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T4459: Deploy swh-indexer > v2.6 on staging then production

Commits

rDMOD9ce6feb9d607: Add support for old dicts in RawExtrinsicMetadata.from_dict

Summary

Format was changed in rDMOD752fb81d86fb15e3d8d39ac1420afb8b5b21adfd.

Fixes https://sentry.softwareheritage.org/share/issue/9b47e02853574f60b4c9b9650923dff1/

Diff Detail

Repository

rDMOD Data model

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 31196
Build 48797: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 48796: arc lint + arc unit

Event Timeline

vlorentz created this revision.Aug 30 2022, 5:54 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 30 2022, 5:54 PM

Build has FAILED

Patch application report for D8350 (id=30150)

Rebasing onto b18535514e...

Current branch diff-target is up to date.

Changes applied before test

commit f119c3b9073c8c3136da63bc8f93558d6fe83242
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 30 17:54:07 2022 +0200

    Add support for old dicts in RawExtrinsicMetadata.from_dict
    
    Format was changed in 752fb81d86fb15e3d8d39ac1420afb8b5b21adfd.

Link to build: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/502/
See console output for more information: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/502/console

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 30 2022, 5:56 PM

Harbormaster failed remote builds in B31195: Diff 30150!

fix test

Build is green

Patch application report for D8350 (id=30151)

Rebasing onto b18535514e...

Current branch diff-target is up to date.

Changes applied before test

commit 9ce6feb9d60716874138fe638d8d195a4e6adbd2
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 30 17:54:07 2022 +0200

    Add support for old dicts in RawExtrinsicMetadata.from_dict
    
    Format was changed in 752fb81d86fb15e3d8d39ac1420afb8b5b21adfd.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/503/ for more details.

Harbormaster completed remote builds in B31196: Diff 30151.Aug 30 2022, 7:01 PM

vlorentz requested review of this revision.Aug 30 2022, 7:01 PM

ardumont edited the summary of this revision. (Show Details)Aug 31 2022, 9:37 AM

vlorentz edited the summary of this revision. (Show Details)Aug 31 2022, 10:17 AM

ardumont accepted this revision.Aug 31 2022, 10:23 AM

This revision is now accepted and ready to land.Aug 31 2022, 10:23 AM

Closed by commit rDMOD9ce6feb9d607: Add support for old dicts in RawExtrinsicMetadata.from_dict (authored by vlorentz). · Explain WhyAug 31 2022, 10:27 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDMOD9ce6feb9d607: Add support for old dicts in RawExtrinsicMetadata.from_dict.

vlorentz added a task: T4459: Deploy swh-indexer > v2.6 on staging then production.Aug 31 2022, 3:00 PM