Page MenuHomeSoftware Heritage

metadata: Drop unsupported key 'type'
ClosedPublic

Authored by ardumont on Aug 30 2022, 10:14 AM.

Details

Summary

Fix issue [1] which prevents indexer journal client from consuming the journal.

[1] https://sentry.softwareheritage.org/share/issue/1d3de3b47c234408889bff5c4f4b0d20/

Related to T4459#90001

Diff Detail

Repository
rDCIDX Metadata indexer
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 31155
Build 48732: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 48731: arc lint + arc unit

Event Timeline

Add comment to explicit why we drop the key type

Build is green

Patch application report for D8340 (id=30112)

Rebasing onto fa0b1de2a3...

Current branch diff-target is up to date.
Changes applied before test
commit 9c3f841e6c3f5e6e104d36f066d06c807f923628
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 30 10:12:54 2022 +0200

    metadata: Drop unsupported key 'type'
    
    Fix issue [1] which prevents indexer journal client from consuming the journal.
    
    [1] https://sentry.softwareheritage.org/share/issue/1d3de3b47c234408889bff5c4f4b0d20/
    
    Related to T4459#90001

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/463/ for more details.

Build is green

Patch application report for D8340 (id=30113)

Rebasing onto fa0b1de2a3...

Current branch diff-target is up to date.
Changes applied before test
commit 6ccaf58671b65638e172928a249653fa7f280480
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Aug 30 10:12:54 2022 +0200

    metadata: Drop unsupported key 'type'
    
    Fix issue [1] which prevents indexer journal client from consuming the journal.
    
    [1] https://sentry.softwareheritage.org/share/issue/1d3de3b47c234408889bff5c4f4b0d20/
    
    Related to T4459#90001

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/464/ for more details.

This revision is now accepted and ready to land.Aug 30 2022, 10:42 AM

Please change the comment to something more descriptive, eg. attribute used by old versions of the model which is not allowed anymore

Adapt according to suggestion

This revision was landed with ongoing or failed builds.Aug 30 2022, 11:09 AM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D8340 (id=30115)

Rebasing onto 85b675fd19...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-465-D8340.
Changes applied before test

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/465/ for more details.