Page MenuHomeSoftware Heritage

Pass 'obj_id' argument to objstorage.add()
ClosedPublic

Authored by vlorentz on Aug 23 2022, 10:34 AM.

Details

Summary

This argument is required by swh-objstorage >= 2.0.0

Diff Detail

Repository
rDOBJSRPL Content replayer
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 30970
Build 48440: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 48439: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D8286 (id=29918)

Rebasing onto 98cbb35af4...

Current branch diff-target is up to date.
Changes applied before test
commit b3fa9116ef894033e9bcb46e147863c79cb9fcee
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 23 10:34:12 2022 +0200

    Pass 'obj_id' argument to objstorage.add()
    
    This argument is required by swh-objstorage >= 2.0.0

See https://jenkins.softwareheritage.org/job/DOBJSRPL/job/tests-on-diff/41/ for more details.

ardumont added a subscriber: ardumont.

no requirement bump on objstorage?

This revision is now accepted and ready to land.Aug 23 2022, 10:40 AM

Nope, older versions allowed obj_id as an optional argument.

swh-objstorage >=2.0.0 is only required to pass dictionaries