Page MenuHomeSoftware Heritage
Differential D8271

deposit: Move administration view into a dedicated django application
ClosedPublic
Actions

Authored by anlambert on Aug 19 2022, 5:30 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Maniphest Tasks
T4398: Create one django application for each webapp feature
Commits
rDWAPPSbde7e0f1c8ab: deposit: Move administration view into a dedicated django application
Summary

Related to T4398

Diff Detail

Repository
rDWAPPS Web applications
Branch
django-apps-refactoring-deposit
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 30928
Build 48370: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 48369: arc lint + arc unit

Event Timeline

anlambert created this revision.Aug 19 2022, 5:30 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptAug 19 2022, 5:30 PM
swh-public-ci added a comment.Aug 19 2022, 5:31 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1990/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1990/console

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 19 2022, 5:31 PM
Harbormaster failed remote builds in B30928: Diff 29875!
anlambert added a child revision: D8272: Remove no longer needed admin folder.Aug 19 2022, 5:31 PM
swh-public-ci added a comment.Aug 19 2022, 5:50 PM

Build is green

Patch application report for D8271 (id=29875)

Rebasing onto f135b35ee5...

Current branch diff-target is up to date.
Changes applied before test
commit bde7e0f1c8ab3c1da8dddf86c8914e5f6f2fa444
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Jul 22 14:42:37 2022 +0200

    deposit: Move administration view into a dedicated django application
    
    Related to T4398

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1993/ for more details.

Harbormaster completed remote builds in B30928: Diff 29875.Aug 19 2022, 5:50 PM
anlambert requested review of this revision.Aug 19 2022, 5:50 PM
vlorentz accepted this revision.Aug 19 2022, 6:04 PM
This revision is now accepted and ready to land.Aug 19 2022, 6:04 PM
Closed by commit rDWAPPSbde7e0f1c8ab: deposit: Move administration view into a dedicated django application (authored by anlambert). · Explain WhyAug 19 2022, 6:22 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPSbde7e0f1c8ab: deposit: Move administration view into a dedicated django application.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
web/
admin/
--
1 line85%
Loading...
common/
5 lines96%
Loading...
1 line95%
Loading...
deposit/
100%
Loading...
deposit/
templates/
templates/
admin/
deposit-admin.html
deposit.html
63 lines--
deposit/
admin/
urls.py
deposit.py
22 lines93%
Loading...
templates/
admin/
--
2 lines--
tests/
admin/
--
deposit/
--
32 lines100%
Loading...
deposit/
admin/
test_views.py
test_deposit.py
4 lines100%
Loading...

Diff 29875

View Options

swh/web/admin/deposit.py

Loading...
View Options

swh/web/admin/urls.py

Loading...
View Options

swh/web/common/urlsindex.py

Loading...
View Options

swh/web/config.py

Loading...
View Options

swh/web/deposit/__init__.py

Loading...
View Options

swh/web/deposit/templates/deposit-admin.html

Loading...
View Options

swh/web/deposit/urls.py

Loading...
View Options

swh/web/templates/admin/deposit.html

Loading...
View Options

swh/web/templates/layout.html

Loading...
View Options

swh/web/tests/admin/test_deposit.py

Loading...
View Options

swh/web/tests/deposit/__init__.py

Loading...
View Options

swh/web/tests/deposit/test_app.py

Loading...
View Options

swh/web/tests/deposit/test_views.py

Loading...
About · Developer information · Legal