Differential D8251

Replace verbose logging with statsd probes
ClosedPublic
Actions

Authored by olasd on Aug 18 2022, 1:31 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T4435: scrubber log verbosity puts a risk on ELK

Commits

rDSCRUBc6f711ecbfb5: Replace verbose logging with statsd probes

Summary

Related to T4435

Diff Detail

Repository

rDSCRUB Datastore Scrubber

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 30855
Build 48247: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 48246: arc lint + arc unit

Event Timeline

olasd created this revision.Aug 18 2022, 1:31 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 18 2022, 1:31 PM

Build is green

Patch application report for D8251 (id=29804)

Rebasing onto 708b2b2ca7...

Current branch diff-target is up to date.

Changes applied before test

commit c6f711ecbfb5c7417a380a1b1af8f9134a21aff4
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Aug 18 13:30:05 2022 +0200

    Replace verbose logging with statsd probes

See https://jenkins.softwareheritage.org/job/DSCRUB/job/tests-on-diff/52/ for more details.

Harbormaster completed remote builds in B30855: Diff 29804.Aug 18 2022, 1:33 PM

olasd requested review of this revision.Aug 18 2022, 1:33 PM

vlorentz accepted this revision.Aug 18 2022, 1:36 PM

This revision is now accepted and ready to land.Aug 18 2022, 1:36 PM

Closed by commit rDSCRUBc6f711ecbfb5: Replace verbose logging with statsd probes (authored by olasd). · Explain WhyAug 18 2022, 2:34 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDSCRUBc6f711ecbfb5: Replace verbose logging with statsd probes.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

swh/

scrubber/

storage_checker.py

23 lines

89%

Diff 29804

View Options

swh/scrubber/storage_checker.py

Replace verbose logging with statsd probesClosedPublicActions