Differential D8216
Include Sentry context tags even when capture_exceptions=False Authored by vlorentz on Aug 8 2022, 3:41 PM.
Details
When capture_exceptions=False, the indexer's caller reports the exception However, because tags were added by indexers within a scope internal
Diff Detail
Event TimelineComment Actions Build was aborted Patch application report for D8216 (id=29630)Rebasing onto e29700bd96... Current branch diff-target is up to date. Changes applied before testcommit 5313be86b3fa1da858592591a2fd51406ce78cf6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon Aug 8 15:40:55 2022 +0200
Include Sentry context tags even when capture_exceptions=False
When capture_exceptions=False, the indexer's caller reports the exception
to Sentry itself.
However, because tags were added by indexers within a scope internal
to the indexers; the scope was closed before returning to the caller,
so these tags were actually not sent to Sentry.Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/411/ Comment Actions Build is green Patch application report for D8216 (id=29630)Rebasing onto e29700bd96... Current branch diff-target is up to date. Changes applied before testcommit 5313be86b3fa1da858592591a2fd51406ce78cf6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon Aug 8 15:40:55 2022 +0200
Include Sentry context tags even when capture_exceptions=False
When capture_exceptions=False, the indexer's caller reports the exception
to Sentry itself.
However, because tags were added by indexers within a scope internal
to the indexers; the scope was closed before returning to the caller,
so these tags were actually not sent to Sentry.See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/412/ for more details. |