Page MenuHomeSoftware Heritage

docker: move all 'static' kafka config entries in env/kafka.env
ClosedPublic

Authored by douardda on Aug 8 2022, 12:19 PM.

Details

Summary

to try to make it a bit less confusing.

Depends on D8212

Diff Detail

Repository
rDENV Development environment
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vsellier added a subscriber: vsellier.

I'm not sure if it's not better to keep the KAFKA_BROKER_ID closed to the instance declaration as it needs to be unique in a cluster and can't be shared between the instances.
But otherwise, thank, it's simpler like that.

This revision is now accepted and ready to land.Aug 8 2022, 1:45 PM