Differential D8207

Initialize 'status' before try block
ClosedPublic
Actions

Authored by vlorentz on Aug 8 2022, 10:33 AM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

Restricted Maniphest Task

Commits

rDLDBASE43597c480640: Initialize 'status' before try block

Summary

It seems that despite setting it in the 'except BaseException' block,
it is still occasionally undefined in the 'finally' block when
triggered by a SystemExit exception.

This should hopefully prevent UnboundLocalError from
being raised from the 'finally' block from now on

Resolves T4236.

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 30671
Build 47959: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 47958: arc lint + arc unit

Event Timeline

vlorentz created this revision.Aug 8 2022, 10:33 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 8 2022, 10:33 AM

Build is green

Patch application report for D8207 (id=29606)

Rebasing onto 0913e11f69...

Current branch diff-target is up to date.

Changes applied before test

commit 43597c480640f885d7b7ab83a97452bcf6436404
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Aug 8 10:32:55 2022 +0200

    Initialize 'status' before try block
    
    It seems that despite setting it in the 'except BaseException' block,
    it is still occasionally undefined in the 'finally' block when
    triggered by a SystemExit exception.
    
    This should hopefully prevent UnboundLocalError from
    being raised from the 'finally' block from now on

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/817/ for more details.

Harbormaster completed remote builds in B30671: Diff 29606.Aug 8 2022, 10:37 AM

vlorentz requested review of this revision.Aug 8 2022, 10:37 AM

anlambert accepted this revision.Aug 8 2022, 10:56 AM

This revision is now accepted and ready to land.Aug 8 2022, 10:56 AM

Closed by commit rDLDBASE43597c480640: Initialize 'status' before try block (authored by vlorentz). · Explain WhyAug 8 2022, 2:33 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDLDBASE43597c480640: Initialize 'status' before try block.