Page MenuHomeSoftware Heritage

Fix flakiness of test_origin_visit_status_get_random_nothing_found
ClosedPublic

Authored by vlorentz on Fri, Aug 5, 11:19 AM.

Details

Summary

start is increased from 13 to 14, because 13 weeks is 91 days,
ie. 30+31+30; so it is sometimes smaller than 3 months.

This was only hit rarely because the number of visits was small,
so this commit also increases the number of visits to make the
test more likely to fail if it should actually fail.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D8193 (id=29570)

Rebasing onto 4825f40a4f...

Current branch diff-target is up to date.
Changes applied before test
commit 56f69e56b81c5abc28cb6e217e298ab95fb501cb
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Aug 5 11:18:46 2022 +0200

    Fix flakiness of test_origin_visit_status_get_random_nothing_found
    
    start is increased from 13 to 14, because 13 weeks is 91 days,
    ie. 30+31+30; so it is sometimes smaller than 3 months.
    
    This was only hit rarely because the number of visits was small,
    so this commit also increases the number of visits to make the
    test more likely to fail if it should actually fail.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1643/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1643/console

Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Aug 5, 11:36 AM
Harbormaster failed remote builds in B30636: Diff 29570!
ardumont added a subscriber: ardumont.

the fix is in D8198

This revision is now accepted and ready to land.Fri, Aug 5, 1:43 PM
This revision was landed with ongoing or failed builds.Fri, Aug 5, 1:47 PM
This revision was automatically updated to reflect the committed changes.