Differential D8173

docs: Mention caveats of using archive checksums as ExtID.
ClosedPublic
Actions

Authored by vlorentz on Aug 3 2022, 12:57 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDBASE0913e11f6991: docs: Mention caveats of using archive checksums as ExtID.

Summary

I realized this wasn't documented while reviewing D8171.

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 30588
Build 47823: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 47822: arc lint + arc unit

Event Timeline

vlorentz created this revision.Aug 3 2022, 12:57 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 3 2022, 12:57 PM

vlorentz mentioned this in D8171: crates: Loader implements incremental mode.Aug 3 2022, 12:58 PM

Build is green

Patch application report for D8173 (id=29515)

Rebasing onto 01547b8edf...

Current branch diff-target is up to date.

Changes applied before test

commit 6bb162b1379477223ca9d6ff0ad4c3b8b264251b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Aug 3 12:55:53 2022 +0200

    docs: Mention caveats of using archive checksums as ExtID.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/814/ for more details.

Harbormaster completed remote builds in B30582: Diff 29515.Aug 3 2022, 1:00 PM

vlorentz requested review of this revision.Aug 3 2022, 1:00 PM

lgtm

one suggestion inline.

docs/package-loader-tutorial.rst
375	we should replacer archive by tarball or something. I keep getting confused when reading the doc.
383

This revision is now accepted and ready to land.Aug 3 2022, 3:06 PM

"extrinsic fields"

This revision was landed with ongoing or failed builds.Aug 3 2022, 3:32 PM

Closed by commit rDLDBASE0913e11f6991: docs: Mention caveats of using archive checksums as ExtID. (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDLDBASE0913e11f6991: docs: Mention caveats of using archive checksums as ExtID..

Build is green

Patch application report for D8173 (id=29521)

Rebasing onto 01547b8edf...

Current branch diff-target is up to date.

Changes applied before test

commit 0913e11f6991a8441c8745010aed4c8daf532fef
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Aug 3 12:55:53 2022 +0200

    docs: Mention caveats of using archive checksums as ExtID.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/815/ for more details.

Harbormaster completed remote builds in B30588: Diff 29521.Aug 3 2022, 3:35 PM