Differential D8156

cli: Add fossology license indexer journal client
ClosedPublic
Actions

Authored by ardumont on Jul 22 2022, 3:31 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T4273: Rewrite indexers as journal clients when relevant

Commits

rDCIDXa3253a0be473: cli: Add fossology license indexer journal client

Summary

Related to T4273

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 30531
Build 47737: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 47736: arc lint + arc unit

Event Timeline

ardumont created this revision.Jul 22 2022, 3:31 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 22 2022, 3:31 PM

ardumont mentioned this in T4273: Rewrite indexers as journal clients when relevant.Jul 22 2022, 3:32 PM

ardumont added inline comments.Jul 22 2022, 3:35 PM

swh/indexer/tests/test_cli.py
789	(It's already done by the fixture storage ^)

vlorentz published this revision for review.Jul 22 2022, 3:38 PM

vlorentz added a subscriber: vlorentz.

vlorentz added inline comments.

swh/indexer/tests/test_cli.py
842–856	move the imports to the top

vlorentz accepted this revision.Jul 22 2022, 3:38 PM

This revision is now accepted and ready to land.Jul 22 2022, 3:38 PM

ardumont added inline comments.Jul 22 2022, 3:39 PM

swh/indexer/tests/test_cli.py
842–856	ah yes, i forgot, thx. (i usually open it locally to ease writing without having to scroll too much...)

Build is green

Patch application report for D8156 (id=29455)

Rebasing onto d0b5f23300...

Current branch diff-target is up to date.

Changes applied before test

commit 913b784770c538d7d11880f8e5c21b10e8679918
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 22 11:43:52 2022 +0200

    Open fossology license indexer to run as journal client
    
    Related to T4273

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/379/ for more details.

Harbormaster completed remote builds in B30531: Diff 29455.Jul 22 2022, 3:42 PM

Adapt according to review

ardumont retitled this revision from Open fossology license indexer to run as journal client to cli: Add fossology license indexer journal client.Jul 22 2022, 3:47 PM

Build is green

Patch application report for D8156 (id=29456)

Rebasing onto d0b5f23300...

Current branch diff-target is up to date.

Changes applied before test

commit a3253a0be473f0345afc1600885cb10f3e6852d0
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jul 22 11:43:52 2022 +0200

    cli: Add fossology license indexer journal client
    
    Related to T4273

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/380/ for more details.

Harbormaster completed remote builds in B30532: Diff 29456.Jul 22 2022, 3:56 PM

Closed by commit rDCIDXa3253a0be473: cli: Add fossology license indexer journal client (authored by ardumont). · Explain WhyJul 22 2022, 4:04 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDCIDXa3253a0be473: cli: Add fossology license indexer journal client.