Differential D8134

hypothesis_strategies: Prevent generation of invalid 'microseconds' values
ClosedPublic
Actions

Authored by vlorentz on Jul 19 2022, 1:36 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDMODb872718ab456: hypothesis_strategies: Prevent generation of invalid 'microseconds' values

Summary

hypothesis.strategies.integers() is inclusive, but microseconds values
greater or equal to 1 million are rejected by the model

Diff Detail

Repository

rDMOD Data model

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 30451
Build 47604: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 47603: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jul 19 2022, 1:36 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 19 2022, 1:36 PM

Build is green

Patch application report for D8134 (id=29377)

Rebasing onto d298c584fe...

Current branch diff-target is up to date.

Changes applied before test

commit b872718ab456159cab9d28c8a028bc0fcde589b5
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jul 19 13:36:27 2022 +0200

    hypothesis_strategies: Prevent generation of invalid 'microseconds' values
    
    hypothesis.strategies.integers() is inclusive, but microseconds values
    greater or equal to 1 million are rejected by the model

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/489/ for more details.

Harbormaster completed remote builds in B30451: Diff 29377.Jul 19 2022, 1:39 PM

vlorentz requested review of this revision.Jul 19 2022, 1:39 PM

vlorentz mentioned this in D8132: protocol spec: Formally define the XML encoding of Codemeta we implicitly use.Jul 19 2022, 1:44 PM

vlorentz mentioned this in D8133: Fix mypy error.

ardumont accepted this revision.Jul 19 2022, 5:07 PM

This revision is now accepted and ready to land.Jul 19 2022, 5:07 PM

Closed by commit rDMODb872718ab456: hypothesis_strategies: Prevent generation of invalid 'microseconds' values (authored by vlorentz). · Explain WhyJul 19 2022, 5:09 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDMODb872718ab456: hypothesis_strategies: Prevent generation of invalid 'microseconds' values.