Page MenuHomeSoftware Heritage

Rename "intrinsic_metadata" field to "jsonld"
ClosedPublic

Authored by vlorentz on Jul 19 2022, 10:26 AM.

Details

Summary

It will soon be used to store and query extrinsic metadata as well

Diff Detail

Repository
rDSEA Archive search
Branch
extrinsic
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 30443
Build 47590: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 47589: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D8130 (id=29369)

Rebasing onto 132b3b1238...

Current branch diff-target is up to date.
Changes applied before test
commit 19a825889cfeac4f9019dcffe121508cf7a41c51
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jul 19 10:24:57 2022 +0200

    Rename "intrinsic_metadata" field to "jsonld"
    
    It will soon be used to store and query extrinsic metadata as well

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/336/ for more details.

Looks good to me, I am wondering if you should not add a field alias to avoid reindexing but still allow search in intrinsic metadata already stored in elasticsearch ?

This revision is now accepted and ready to land.Jul 19 2022, 10:47 AM

good point, I didn't think of that.

However, we will migrate this at the same time as T4397, so it's not worth it