Differential D8118

Improve hiring banner embedding for django website
ClosedPublic
Actions

Authored by anlambert on Jul 12 2022, 6:16 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDWAPPS6f9d36afe484: Improve hiring banner embedding for django website

Summary

Prefer to use a div instead of an iframe to avoid blinking banner
on page load.

Nevertheless, keep the iframe view to ease embedding in external
WordPress website.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Jul 12 2022, 6:16 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 12 2022, 6:16 PM

vlorentz published this revision for review.Jul 12 2022, 6:18 PM

vlorentz accepted this revision.

This revision is now accepted and ready to land.Jul 12 2022, 6:18 PM

Build is green

Patch application report for D8118 (id=29330)

Rebasing onto 36f971347d...

Current branch diff-target is up to date.

Changes applied before test

commit 6f9d36afe4840dc3b2424363731c4196b97e14bd
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jul 12 18:15:34 2022 +0200

    Improve hiring banner embedding for django website
    
    Prefer to use a div instead of an iframe to avoid blinking banner
    on page load.
    
    Nevertheless, keep the iframe view to ease embedding in external
    WordPress website.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1929/ for more details.

Harbormaster completed remote builds in B30409: Diff 29330.Jul 12 2022, 6:31 PM

Closed by commit rDWAPPS6f9d36afe484: Improve hiring banner embedding for django website (authored by anlambert). · Explain WhyJul 12 2022, 6:44 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS6f9d36afe484: Improve hiring banner embedding for django website.