Differential D8030

Fix crash on directories pointing to missing contents
ClosedPublic
Actions

Authored by vlorentz on Jun 23 2022, 10:04 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T4345: get_filtered_files_content fails with "unexpected status None for content"

Commits

rDVAU141b4531b1a6: Fix crash on directories pointing to missing contents

Summary

This can happen for various reasons, such as running the vault on
a mirror that is partially replayed

Resolves T4345.

Diff Detail

Repository

rDVAU Software Heritage Vault

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jun 23 2022, 10:04 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 23 2022, 10:04 AM

Build is green

Patch application report for D8030 (id=28918)

Rebasing onto 6da99426e2...

Current branch diff-target is up to date.

Changes applied before test

commit 141b4531b1a6924806787252db15172422553c04
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Jun 23 10:04:16 2022 +0200

    Fix crash on directories pointing to missing contents
    
    This can happen for various reasons, such as running the vault on
    a mirror that is partially replayed

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/240/ for more details.

Harbormaster completed remote builds in B30011: Diff 28918.Jun 23 2022, 10:07 AM

vlorentz requested review of this revision.Jun 23 2022, 10:07 AM

ardumont accepted this revision.Jun 24 2022, 11:26 AM

This revision is now accepted and ready to land.Jun 24 2022, 11:26 AM

Closed by commit rDVAU141b4531b1a6: Fix crash on directories pointing to missing contents (authored by vlorentz). · Explain WhyJun 27 2022, 3:12 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDVAU141b4531b1a6: Fix crash on directories pointing to missing contents.