Page MenuHomeSoftware Heritage

Make WineryWriter.add return None
ClosedPublic

Authored by vlorentz on Wed, Jun 22, 4:56 PM.

Details

Summary

Like WineryObjStorage and other ObjStorage backends.

Diff Detail

Repository
rDOBJS Object storage
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D8028 (id=28912)

Could not rebase; Attempt merge onto 847285a28d...

Updating 847285a..3491bf7
Fast-forward
 swh/objstorage/backends/pathslicing.py             | 33 +---------------------
 swh/objstorage/backends/winery/objstorage.py       |  8 ++----
 swh/objstorage/interface.py                        | 25 +---------------
 swh/objstorage/multiplexer/filter/filter.py        |  3 --
 swh/objstorage/multiplexer/filter/id_filter.py     |  5 ----
 .../multiplexer/multiplexer_objstorage.py          | 20 +------------
 swh/objstorage/objstorage.py                       |  5 +---
 swh/objstorage/tests/test_multiplexer_filter.py    | 19 -------------
 .../tests/test_objstorage_multiplexer.py           |  7 -----
 .../tests/test_objstorage_pathslicing.py           |  7 -----
 swh/objstorage/tests/test_objstorage_winery.py     | 13 ++++-----
 11 files changed, 12 insertions(+), 133 deletions(-)
Changes applied before test
commit 3491bf7eb24c7aaed2eabdef664787cb6a1aabdd
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Jun 22 16:56:39 2022 +0200

    Make WineryWriter.add return None
    
    Like WineryObjStorage and other ObjStorage backends.

commit 0fd9cefc33d50b1a345a3c965b7f63d7bcf58d61
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Jun 22 16:18:47 2022 +0200

    Remove get_random()
    
    It is not used anywhere (and swh-storage provides content_get_random() that
    feels the same need), and cloud backends do not implement it anyway.

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/162/ for more details.

This revision is now accepted and ready to land.Wed, Jun 22, 5:25 PM

Build is green

Patch application report for D8028 (id=28924)

Could not rebase; Attempt merge onto d7f4daa242...

Updating d7f4daa..e712f28
Fast-forward
 swh/objstorage/backends/pathslicing.py             | 33 +---------------------
 swh/objstorage/backends/winery/objstorage.py       |  8 ++----
 swh/objstorage/interface.py                        | 25 +---------------
 swh/objstorage/multiplexer/filter/filter.py        |  3 --
 swh/objstorage/multiplexer/filter/id_filter.py     |  5 ----
 .../multiplexer/multiplexer_objstorage.py          | 20 +------------
 swh/objstorage/objstorage.py                       |  5 +---
 swh/objstorage/tests/test_multiplexer_filter.py    | 19 -------------
 .../tests/test_objstorage_multiplexer.py           |  7 -----
 .../tests/test_objstorage_pathslicing.py           |  7 -----
 swh/objstorage/tests/test_objstorage_winery.py     | 13 ++++-----
 11 files changed, 12 insertions(+), 133 deletions(-)
Changes applied before test
commit e712f28684a1a17233a700dd22606b594a3b617b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Jun 22 16:56:39 2022 +0200

    Make WineryWriter.add return None
    
    Like WineryObjStorage and other ObjStorage backends.

commit 2caa05e869c952a3e8c4f3418d41ea17955f5447
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Jun 22 16:18:47 2022 +0200

    Remove get_random()
    
    It is not used anywhere (and swh-storage provides content_get_random() that
    feels the same need), and cloud backends do not implement it anyway.

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/166/ for more details.

This revision was automatically updated to reflect the committed changes.