Differential D8021

to_disk: Add type annotations + a simple test for DirectoryBuilder
ClosedPublic
Actions

Authored by vlorentz on Jun 22 2022, 3:36 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T4345: get_filtered_files_content fails with "unexpected status None for content"

Commits

rDVAU6da99426e215: to_disk: Add type annotations + a simple test for DirectoryBuilder

Diff Detail

Repository

rDVAU Software Heritage Vault

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jun 22 2022, 3:36 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 22 2022, 3:36 PM

Build is green

Patch application report for D8021 (id=28892)

Rebasing onto 8ac000b4e1...

Current branch diff-target is up to date.

Changes applied before test

commit 6da99426e215b20f1100abac5cb85a2c72ee183d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Jun 22 15:36:43 2022 +0200

    to_disk: Add type annotations + a simple test for DirectoryBuilder

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/239/ for more details.

Harbormaster completed remote builds in B29980: Diff 28892.Jun 22 2022, 3:40 PM

vlorentz requested review of this revision.Jun 22 2022, 3:40 PM

ardumont accepted this revision.Jun 22 2022, 4:37 PM

This revision is now accepted and ready to land.Jun 22 2022, 4:37 PM

Closed by commit rDVAU6da99426e215: to_disk: Add type annotations + a simple test for DirectoryBuilder (authored by vlorentz). · Explain WhyJun 23 2022, 9:46 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDVAU6da99426e215: to_disk: Add type annotations + a simple test for DirectoryBuilder.

vlorentz added a task: T4345: get_filtered_files_content fails with "unexpected status None for content".Jun 23 2022, 9:47 AM

Revision Contents
Changeset List

Path

Size

swh/

vault/

tests/

test_to_disk.py

62 lines

to_disk.py

14 lines

Diff 28917

View Options

swh/vault/tests/test_to_disk.py