Page MenuHomeSoftware Heritage

Always set object id when adding objects to objstorage
ClosedPublic

Authored by olasd on Tue, Jun 21, 4:21 PM.

Diff Detail

Repository
rDOBJSRPL Content replayer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D8011 (id=28866)

Rebasing onto b712763909...

First, rewinding head to replay your work on top of it...
Applying: Always set object id when adding objects to objstorage
Changes applied before test
commit 8181be98b86c9a89181bcdb68a8f4e69ef060a42
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Jun 21 16:20:27 2022 +0200

    Always set object id when adding objects to objstorage
    
    The obj_id-less form is being deprecated.

Link to build: https://jenkins.softwareheritage.org/job/DOBJSRPL/job/tests-on-diff/38/
See console output for more information: https://jenkins.softwareheritage.org/job/DOBJSRPL/job/tests-on-diff/38/console

Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Jun 21, 4:21 PM
Harbormaster failed remote builds in B29953: Diff 28866!

Build is green

Patch application report for D8011 (id=28867)

Rebasing onto b712763909...

Current branch diff-target is up to date.
Changes applied before test
commit 8b7223480f665684c3d635e3df9edaf8efa4b023
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Jun 21 16:20:27 2022 +0200

    Always set object id when adding objects to objstorage
    
    The obj_id-less form is being deprecated.

See https://jenkins.softwareheritage.org/job/DOBJSRPL/job/tests-on-diff/39/ for more details.

olasd requested review of this revision.Tue, Jun 21, 5:14 PM
This revision is now accepted and ready to land.Tue, Jun 21, 5:49 PM