Page MenuHomeSoftware Heritage

cvsclient: Allow to connect to a pserver URL without password
ClosedPublic

Authored by anlambert on Fri, Jun 17, 4:41 PM.

Details

Summary

The CVS client was raising an error when trying to connect to such pserver
URL: pserver://anonymous@cvs.example.org/cvsroot/project/module

But numerous CVS pserver URLs that can be found in the wild (notably on
SourceForge and OSDN) are in that form.

So add support for such URL form in the CVS client.

Diff Detail

Repository
rDLDCVS CVS Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D8004 (id=28840)

Rebasing onto d52686be91...

Current branch diff-target is up to date.
Changes applied before test
commit eeb3cee1e1ca41078622f1fab168622876edbc9f
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Jun 17 16:36:34 2022 +0200

    cvsclient: Allow to connect to a pserver URL without password
    
    The CVS client was raising an error when trying to connect to such pserver
    URL: pserver://anonymous@cvs.example.org/cvsroot/project/module
    
    But numerous CVS pserver URLs that can be found in the wild (notably on
    SourceForge and OSDN) are in that form.
    
    So add support for such URL form in the CVS client.

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/112/ for more details.

Remove use of urllib3.util.parse_url and prefer to use urllib.parse.urlparse from standard library instead.

Build is green

Patch application report for D8004 (id=28842)

Rebasing onto d52686be91...

Current branch diff-target is up to date.
Changes applied before test
commit e382aeb0526618ef5a7345551166ec46137fae93
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Jun 17 16:36:34 2022 +0200

    cvsclient: Allow to connect to a pserver URL without password
    
    The CVS client was raising an error when trying to connect to such pserver
    URL: pserver://anonymous@cvs.example.org/cvsroot/project/module
    
    But numerous CVS pserver URLs that can be found in the wild (notably on
    SourceForge and OSDN) are in that form.
    
    So add support for such URL form in the CVS client.
    
    Also remove use of external dependency urllib3.util.parse_url and prefer
    to use urllib.parse.urlparse from standard Python library.

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/114/ for more details.

This revision is now accepted and ready to land.Sat, Jun 18, 4:14 PM