Differential D7991

Use query variables instead of f-strings in functional tests
ClosedPublic
Actions

Authored by jayeshv on Jun 14 2022, 3:50 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T4306: Use query variables instead of f-strings in swh-graphql tests

Commits

rDGQL2c457bf0bc7f: Use query variables instead of f-strings in functional tests

Summary

Related to T4306

Diff Detail

Repository

rDGQL GraphQL API

Branch

test-refactor

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 29864
Build 46680: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 46679: arc lint + arc unit

Event Timeline

jayeshv created this revision.Jun 14 2022, 3:50 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 14 2022, 3:50 PM

Build is green

Patch application report for D7991 (id=28781)

Rebasing onto 67e0bf7370...

Current branch diff-target is up to date.

Changes applied before test

commit 2c457bf0bc7f5de2fcb9bb11b505b496f4a064b8
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Jun 14 15:46:21 2022 +0200

    Use query variables instead of f-strings in functional tests
    
    Related to T4306

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/60/ for more details.

Harbormaster completed remote builds in B29864: Diff 28781.Jun 14 2022, 3:52 PM

jayeshv requested review of this revision.Jun 14 2022, 3:52 PM

anlambert accepted this revision.Jun 14 2022, 4:13 PM

This revision is now accepted and ready to land.Jun 14 2022, 4:13 PM

Closed by commit rDGQL2c457bf0bc7f: Use query variables instead of f-strings in functional tests (authored by jayeshv). · Explain WhyJun 14 2022, 4:15 PM

This revision was automatically updated to reflect the committed changes.

jayeshv added a commit: rDGQL2c457bf0bc7f: Use query variables instead of f-strings in functional tests.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

swh/

graphql/

tests/

functional/

test_snapshot_node.py

24 lines

100%

test_visit_node.py

28 lines

100%

Diff 28781

View Options

swh/graphql/tests/functional/test_snapshot_node.py