Remove unnecessary base exception
ClosedPublic
Actions

Authored by jayeshv on Jun 14 2022, 12:32 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDGQL736748edd277: Remove unnecessary base exception

Diff Detail

Repository

rDGQL GraphQL API

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jayeshv created this revision.Jun 14 2022, 12:32 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 14 2022, 12:32 PM

Build is green

Patch application report for D7986 (id=28773)

Rebasing onto 67f1ae16f5...

Current branch diff-target is up to date.

Changes applied before test

commit 736748edd27793209d522607e13edc6c5bf625d6
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Jun 14 12:31:37 2022 +0200

    Remove unnecessary base exception

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/56/ for more details.

Harbormaster completed remote builds in B29855: Diff 28773.Jun 14 2022, 12:34 PM

jayeshv requested review of this revision.Jun 14 2022, 12:34 PM

jayeshv mentioned this in D7984: Add error handling for pagination input arguments.Jun 14 2022, 12:35 PM

That's better like this indeed, the caught of the base Exception was confusing to me.

This revision is now accepted and ready to land.Jun 14 2022, 12:39 PM

Closed by commit rDGQL736748edd277: Remove unnecessary base exception (authored by jayeshv). · Explain WhyJun 14 2022, 12:42 PM

This revision was automatically updated to reflect the committed changes.

jayeshv added a commit: rDGQL736748edd277: Remove unnecessary base exception.

Revision Contents
Changeset List

Path

Size

swh/

graphql/

resolvers/

base_connection.py

2 lines

Diff 28774

View Options

swh/graphql/resolvers/base_connection.py

Remove unnecessary base exceptionClosedPublicActions