Page MenuHomeSoftware Heritage
Differential D796

loader.tar: Cover the remote use cases in tests
ClosedPublic
Actions

Authored by ardumont on Dec 10 2018, 12:24 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Maniphest Tasks
T1431: Add tests for the Tar loader.
Commits
rDLDTAR33fc89ac2bc9: tests: Improve docstring declaration
rDLDTARc375e9f79492: tests: Rename test class
rDLDTAR2fea4e0a4dc7: test_loader: Add download failure scenario
rDLDTARa0eb9791dbf0: tests: Remove blank spaces
rDLDTAR1e5b9cb3ce73: tests: Move fs marker to the upper class
rDLDTARaabf1010cf3e: tar.loader: Reuse swh.model.hashutil.HASH_BLOCK_SIZE
rDLDTARc3577a11cc67: test_loader: Refactor tests
rDLDTAR03df15fba7d7: loader.tar: Cover the remote use case in test
Summary
  • Download
  • Download failures

Close T1431

Test Plan

tox

Diff Detail

Repository
rDLDTAR Tarball Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Dec 10 2018, 12:24 PM
swh-public-ci added a subscriber: swh-public-ci.Dec 10 2018, 12:26 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDTAR/job/tox/61/ for more details.

Harbormaster completed remote builds in B2962: Diff 2537.Dec 10 2018, 12:26 PM
ardumont updated this revision to Diff 2538.Dec 10 2018, 12:29 PM

d/control: Fix tab typo

swh-public-ci added a comment.Dec 10 2018, 12:30 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDTAR/job/tox/62/ for more details.

Harbormaster completed remote builds in B2963: Diff 2538.Dec 10 2018, 12:30 PM
ardumont edited the summary of this revision. (Show Details)Dec 10 2018, 1:17 PM
ardumont added a task: T1431: Add tests for the Tar loader..
vlorentz accepted this revision.Dec 10 2018, 1:46 PM
vlorentz added inline comments.
swh/loader/tar/tests/test_loader.py
45

Should be decorated with @pytest.mark.fs

126

Remove that decorator from the test and move it to the class (all tests of the class use the FS)

This revision is now accepted and ready to land.Dec 10 2018, 1:46 PM
ardumont added a comment.Dec 10 2018, 1:47 PM

Should be decorated with @pytest.mark.fs
Remove that decorator from the test and move it to the class (all tests of the class use the FS)

Correct!

ardumont updated this revision to Diff 2539.Dec 10 2018, 1:52 PM
  • tests: Move fs marker to the upper class
  • tests: Remove blank spaces
  • tests: Rename test class
  • tests: Improve docstring declaration
swh-public-ci added a comment.Dec 10 2018, 1:53 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDTAR/job/tox/63/ for more details.

Harbormaster completed remote builds in B2964: Diff 2539.Dec 10 2018, 1:53 PM
Closed by commit rDLDTAR03df15fba7d7: loader.tar: Cover the remote use case in test (authored by ardumont). · Explain WhyDec 10 2018, 1:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
debian/
1 line
1 line
swh/
loader/
tar/
3 lines
tests/
71 lines

Diff 2540

View Options

debian/control

Loading...
View Options

requirements-test.txt

Loading...
View Options

swh/loader/tar/loader.py

Loading...
View Options

swh/loader/tar/tests/test_loader.py

Loading...
About · Developer information · Legal