Page MenuHomeSoftware Heritage

Add Snapshot, Content and Directory objects as target in branch
ClosedPublic

Authored by jayeshv on Jun 8 2022, 12:12 PM.

Details

Summary

A branch target can be a snapshot, alias, revision, release, content or a directory.
This commit adds support for Snapshot, Content and Directory objects.

Related to T4309

Diff Detail

Repository
rDGQL GraphQL API
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D7969 (id=28713)

Rebasing onto ce6095a3e0...

Current branch diff-target is up to date.
Changes applied before test
commit 51a82af9af86af16406cd9906318970099bc9cf4
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Jun 7 16:49:39 2022 +0200

    Add Snapshot, Content and Directory objects as target in branch
    
    A branch target can be a snapshot, alias, revision, release, content or a directory.
    This commit adds support for Snapshot, Content and Directory objects.
    
    Related to T4309

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/45/ for more details.

Remove unnecessary comment

Build is green

Patch application report for D7969 (id=28715)

Rebasing onto ce6095a3e0...

Current branch diff-target is up to date.
Changes applied before test
commit a3df4ec60f333cd10c95571b97951a83d9b5cdea
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Jun 7 16:49:39 2022 +0200

    Add Snapshot, Content and Directory objects as target in branch
    
    A branch target can be a snapshot, alias, revision, release, content or a directory.
    This commit adds support for Snapshot, Content and Directory objects.
    
    Related to T4309

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/46/ for more details.

vlorentz added a subscriber: vlorentz.

why percent-substitution instead of f-strings in new tests? is it in preparation for T4306?

This revision is now accepted and ready to land.Jun 8 2022, 1:20 PM

why percent-substitution instead of f-strings in new tests? is it in preparation for T4306?

Yes, I will change other tests in another diff