Differential D7958

Remove unused get_current_version method
ClosedPublic
Actions

Authored by ardumont on Jun 3 2022, 2:42 PM.

Details

Reviewers

douardda

Group Reviewers

Reviewers

Maniphest Tasks

T4305: Aligh swh backends for migration tools to work

Commits

rDSCH0496c3977a56: Remove unused get_current_version method

Summary

Attribute current_version is already set and directly used by swh db
[version|init|upgrade] clis.

Related to T4305

Diff Detail

Repository

rDSCH Scheduling utilities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jun 3 2022, 2:42 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 3 2022, 2:43 PM

Update requirements

Build is green

Patch application report for D7958 (id=28664)

Rebasing onto ef1538503d...

First, rewinding head to replay your work on top of it...
Applying: Remove unused get_current_version method

Changes applied before test

commit 5a24b40de09f7e1dcfd7a897888afea75c0bdf43
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jun 3 14:41:51 2022 +0200

    Remove unused get_current_version method
    
    Attribute current_version is already set and directly used by swh db
    [version|init|upgrade] clis.
    
    Related to T4305

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/552/ for more details.

Harbormaster completed remote builds in B29748: Diff 28664.Jun 3 2022, 2:50 PM

ardumont mentioned this in T4305: Aligh swh backends for migration tools to work.Jun 3 2022, 2:50 PM

Build is green

Patch application report for D7958 (id=28665)

Rebasing onto ef1538503d...

Current branch diff-target is up to date.

Changes applied before test

commit 0496c3977a56b66dbbe2682bcb8f37390f650c1f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Jun 3 14:41:51 2022 +0200

    Remove unused get_current_version method
    
    Attribute current_version is already set and directly used by swh db
    [version|init|upgrade] clis.
    
    Related to T4305

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/553/ for more details.

Harbormaster completed remote builds in B29749: Diff 28665.Jun 3 2022, 2:52 PM

ardumont requested review of this revision.Jun 3 2022, 2:52 PM

douardda accepted this revision.Jun 3 2022, 3:29 PM

This revision is now accepted and ready to land.Jun 3 2022, 3:29 PM

Closed by commit rDSCH0496c3977a56: Remove unused get_current_version method (authored by ardumont). · Explain WhyJun 3 2022, 3:33 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSCH0496c3977a56: Remove unused get_current_version method.