Related to T4261
Details
Details
- Reviewers
vlorentz ardumont - Group Reviewers
Reviewers - Maniphest Tasks
- T4261: Swh-graphql Code cleanup
- Commits
- rDGQL267732ffffef: Improve doc strings and inline documentation
Diff Detail
Diff Detail
- Repository
- rDGQL GraphQL API
- Branch
- doc-cleanup
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 29685 Build 46392: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 46391: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D7942 (id=28603)
Rebasing onto c8ef46e760...
Current branch diff-target is up to date.
Changes applied before test
commit 8accb28a366248fc8741d7d8d1127182573091fa
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date: Tue May 31 14:04:50 2022 +0200
Improve doc strings and inline documentation
Related to T4261See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/38/ for more details.
Comment Actions
Build is green
Patch application report for D7942 (id=28604)
Rebasing onto c8ef46e760...
Current branch diff-target is up to date.
Changes applied before test
commit 93ceb8cb3deb9f0ead66b9111a79eb35fbed1cc6
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date: Tue May 31 14:04:50 2022 +0200
Improve doc strings and inline documentation
Related to T4261See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/39/ for more details.
Comment Actions
some comments below for the first files in the diff, but they apply to others too
| swh/graphql/resolvers/content.py | ||
|---|---|---|
| 48–49 | redundant | |
| swh/graphql/resolvers/directory.py | ||
| 49 | s/required/requested/ ? | |
| 49–50 | add a type annotation instead | |
| 60–61 | ditto | |
| swh/graphql/resolvers/directory_entry.py | ||
| 31 | would an annotation work here too? | |
| swh/graphql/resolvers/resolvers.py | ||
| 11 | ||
Comment Actions
Build is green
Patch application report for D7942 (id=28605)
Rebasing onto c8ef46e760...
Current branch diff-target is up to date.
Changes applied before test
commit 418b121b4d5aa34b745c1e523bb6eb0a128bb829
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date: Tue May 31 14:04:50 2022 +0200
Improve doc strings and inline documentation
Add type hints for parent objects in a resolver
Related to T4261See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/40/ for more details.
Comment Actions
Build is green
Patch application report for D7942 (id=28606)
Rebasing onto c8ef46e760...
Current branch diff-target is up to date.
Changes applied before test
commit f00e0fd49273095c9576d42b8c11122ead974e1b
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date: Tue May 31 14:04:50 2022 +0200
Improve doc strings and inline documentation
Add type hints for parent objects in a resolver
Related to T4261See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/41/ for more details.
Comment Actions
Build is green
Patch application report for D7942 (id=28622)
Rebasing onto c8ef46e760...
Current branch diff-target is up to date.
Changes applied before test
commit 267732ffffefbc569fcc31af04c9825b60bf3ff3
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date: Tue May 31 14:04:50 2022 +0200
Improve doc strings and inline documentation
Add type hints for parent objects in a resolver
Related to T4261See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/42/ for more details.