Differential D7921

Convert test_origin_head from unittest to pytest
ClosedPublic
Actions

Authored by vlorentz on May 31 2022, 2:28 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDCIDXf8f96257547c: Convert test_origin_head from unittest to pytest

Summary

A future commit will significantly change test initialization,
and using fixtures simplifies this.

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 29630
Build 46308: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 46307: arc lint + arc unit

Event Timeline

vlorentz created this revision.May 31 2022, 2:28 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 31 2022, 2:28 PM

Build is green

Patch application report for D7921 (id=28539)

Could not rebase; Attempt merge onto ecc84f3760...

Updating ecc84f3..f8f9625
Fast-forward
 swh/indexer/cli.py                    |  49 ++++--
 swh/indexer/indexer.py                |   4 -
 swh/indexer/tests/test_cli.py         |   4 +-
 swh/indexer/tests/test_origin_head.py | 303 +++++++++++++++++-----------------
 4 files changed, 184 insertions(+), 176 deletions(-)

Changes applied before test

commit f8f96257547cfd7a78c21df08ab83193ffbd9bf7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue May 31 14:27:48 2022 +0200

    Convert test_origin_head from unittest to pytest
    
    A future commit will significantly change test initialization,
    and using fixtures simplifies this.

commit ff728e0541b36edb583f8fbad979e1f58a51d588
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue May 31 12:25:30 2022 +0200

    cli: Add support for running "all" indexers in the journal client
    
    There is only the origin-intrinsic-metadata indexer for now,
    but others will be added in the future

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/235/ for more details.

Harbormaster completed remote builds in B29630: Diff 28539.May 31 2022, 2:34 PM

vlorentz requested review of this revision.May 31 2022, 2:34 PM

ardumont accepted this revision.May 31 2022, 2:36 PM

This revision is now accepted and ready to land.May 31 2022, 2:36 PM

Closed by commit rDCIDXf8f96257547c: Convert test_origin_head from unittest to pytest (authored by vlorentz). · Explain WhyMay 31 2022, 3:42 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDCIDXf8f96257547c: Convert test_origin_head from unittest to pytest.