Differential D7893

Refactor base indexers to provide a process_journal_objects method
ClosedPublic
Actions

Authored by vlorentz on May 25 2022, 2:54 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T4273: Rewrite indexers as journal clients when relevant

Commits

rDCIDX35ff46ef5bb2: Refactor base indexers to provide a process_journal_objects method

Summary

It will be used in a future commit to run indexers directly from
a journal client.

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 29565
Build 46199: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 46198: arc lint + arc unit

Event Timeline

vlorentz created this revision.May 25 2022, 2:54 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 25 2022, 2:54 PM

Build is green

Patch application report for D7893 (id=28475)

Rebasing onto 32236e69eb...

Current branch diff-target is up to date.

Changes applied before test

commit 35ff46ef5bb2acf6d93b1cc18f9ad1378d09cba8
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed May 25 14:47:41 2022 +0200

    Refactor base indexers to provide a process_journal_objects method
    
    It will be used in a future commit to run indexers directly from
    a journal client.

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/230/ for more details.

Harbormaster completed remote builds in B29565: Diff 28475.May 25 2022, 2:59 PM

vlorentz requested review of this revision.May 25 2022, 2:59 PM

vlorentz added a task: T4273: Rewrite indexers as journal clients when relevant.May 25 2022, 3:40 PM

vlorentz added a child revision: D7899: Add support for indexing directly from the journal client.

ardumont accepted this revision.May 25 2022, 5:12 PM

This revision is now accepted and ready to land.May 25 2022, 5:12 PM

Closed by commit rDCIDX35ff46ef5bb2: Refactor base indexers to provide a process_journal_objects method (authored by vlorentz). · Explain WhyMay 30 2022, 3:55 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDCIDX35ff46ef5bb2: Refactor base indexers to provide a process_journal_objects method.