Differential D7889

cff: Do not change yaml.SafeLoader globally
ClosedPublic
Actions

Authored by vlorentz on May 24 2022, 5:53 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDCIDXf69131fbec04: cff: Do not change yaml.SafeLoader globally

Summary

It may have unexpected side-effects

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 29556
Build 46184: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 46183: arc lint + arc unit

Event Timeline

vlorentz created this revision.May 24 2022, 5:53 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 24 2022, 5:53 PM

Build is green

Patch application report for D7889 (id=28466)

Rebasing onto 3adc5a408f...

Current branch diff-target is up to date.

Changes applied before test

commit f69131fbec04c75e76490718d3da5bde73cdb4b2
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue May 24 17:53:02 2022 +0200

    cff: Do not change yaml.SafeLoader globally
    
    It may have unexpected side-effects

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/228/ for more details.

Harbormaster completed remote builds in B29556: Diff 28466.May 24 2022, 5:58 PM

vlorentz requested review of this revision.May 24 2022, 5:58 PM

ardumont accepted this revision.May 24 2022, 7:57 PM

This revision is now accepted and ready to land.May 24 2022, 7:57 PM

Closed by commit rDCIDXf69131fbec04: cff: Do not change yaml.SafeLoader globally (authored by vlorentz). · Explain WhyMay 25 2022, 9:49 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDCIDXf69131fbec04: cff: Do not change yaml.SafeLoader globally.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

swh/

indexer/

metadata_dictionary/

cff.py

12 lines

100%

Diff 28466

View Options

swh/indexer/metadata_dictionary/cff.py

cff: Do not change yaml.SafeLoader globallyClosedPublicActions