Use GitHubSession to make canonical computation deal with rate limit
ClosedPublic
Actions

Authored by ardumont on May 20 2022, 12:48 PM.

Details

Reviewers

vlorentz
anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T4232: Listers: Canonicalize listed github origins

Commits

rDCOREcbcbf0102f30: Use GitHubSession to make canonical computation deal with rate limit

Summary

Related to T4232

Diff Detail

Repository

rDCORE Foundations and core functionalities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.May 20 2022, 12:48 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 20 2022, 12:48 PM

ardumont mentioned this in D7840: Refactor swh.lister.github.utils to swh.core.github.utils.May 20 2022, 12:48 PM

Build is green

Patch application report for D7870 (id=28411)

Rebasing onto 9fa9f84227...

Current branch diff-target is up to date.

Changes applied before test

commit 11fec1cfdf5629a97e11d1c50483959480666e81
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Fri May 20 12:47:41 2022 +0200

    Use GitHubSession to make canonical computation deal with rate limit
    
    Related to T4232

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/424/ for more details.

Harbormaster completed remote builds in B29502: Diff 28411.May 20 2022, 12:50 PM

ardumont requested review of this revision.May 20 2022, 12:50 PM

Add tests around github session as well

Build is green

Patch application report for D7870 (id=28412)

Rebasing onto 9fa9f84227...

Current branch diff-target is up to date.

Changes applied before test

commit cbcbf0102f304b9e76dac26a5d6a409b4c4d8c3f
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Fri May 20 12:47:41 2022 +0200

    Use GitHubSession to make canonical computation deal with rate limit
    
    Related to T4232

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/425/ for more details.

Harbormaster completed remote builds in B29503: Diff 28412.May 20 2022, 12:55 PM

vlorentz accepted this revision.May 20 2022, 1:42 PM

This revision is now accepted and ready to land.May 20 2022, 1:42 PM

anlambert accepted this revision.May 20 2022, 2:13 PM

Closed by commit rDCOREcbcbf0102f30: Use GitHubSession to make canonical computation deal with rate limit (authored by ardumont). · Explain WhyMay 20 2022, 3:26 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDCOREcbcbf0102f30: Use GitHubSession to make canonical computation deal with rate limit.

ardumont mentioned this in T4232: Listers: Canonicalize listed github origins.May 20 2022, 3:34 PM