Move store_data from DVCSLoader to a new BaseGitLoader
ClosedPublic
Actions

Authored by vlorentz on May 20 2022, 12:16 PM.

Details

Reviewers

anlambert
ardumont

Group Reviewers

Reviewers

Commits

rDLDG083e1aa18e24: Move store_data from DVCSLoader to a new BaseGitLoader

Summary

In preparation for the removal of DVCSLoader from swh.loader.core,
as the git loader is the only one to use it anymore.

Diff Detail

Repository

rDLDG Git loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.May 20 2022, 12:16 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 20 2022, 12:16 PM

Build is green

Patch application report for D7868 (id=28409)

Rebasing onto 85a4794094...

Current branch diff-target is up to date.

Changes applied before test

commit 083e1aa18e24cd3311162e259b15c1867b313060
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri May 20 12:16:23 2022 +0200

    Move store_data from DVCSLoader to a new BaseGitLoader
    
    In preparation for the removal of DVCSLoader from swh.loader.core,
    as the git loader is the only one to use it anymore.

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/215/ for more details.

Harbormaster completed remote builds in B29500: Diff 28409.May 20 2022, 12:19 PM

vlorentz requested review of this revision.May 20 2022, 12:19 PM

anlambert accepted this revision.May 20 2022, 12:27 PM

This revision is now accepted and ready to land.May 20 2022, 12:27 PM

vlorentz added a child revision: D7871: Add metrics in store_data on ratios of objects already stored.May 20 2022, 1:47 PM

ardumont accepted this revision.May 20 2022, 3:49 PM

Closed by commit rDLDG083e1aa18e24: Move store_data from DVCSLoader to a new BaseGitLoader (authored by vlorentz). · Explain WhyMay 23 2022, 1:54 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDLDG083e1aa18e24: Move store_data from DVCSLoader to a new BaseGitLoader.

ardumont mentioned this in D8845: Drop unused core.loader.DVCSLoader class.Nov 15 2022, 12:05 PM

ardumont mentioned this in rDLDBASE31ab1aa69e5b: Drop unused core.loader.DVCSLoader class.Nov 15 2022, 12:12 PM