Differential D7844

Allow icinga checks to write prometheus metrics files
ClosedPublic
Actions

Authored by vsellier on May 17 2022, 8:24 PM.

Details

Reviewers

ardumont

Group Reviewers

System administrators

Maniphest Tasks

T3129: Reliable monitoring of services: for users and for admins

Commits

rSPSITE8c8590ef6fad: Allow icinga checks to write prometheus metrics files

Summary

The prometheus data are readable by everyone so adding icinga in
the prometheus groups seems to not open any hole

Related to T3129

Test Plan

pergamon (collected resources not visible)

diff origin/production/pergamon.softwareheritage.org current/pergamon.softwareheritage.org
*******************************************
+ File[/var/lib/prometheus/node-exporter] =>
   parameters =>
     "ensure": "directory",
     "group": "prometheus",
     "mode": "0775",
     "owner": "prometheus"
*******************************************
*** End octocatalog-diff on pergamon.softwareheritage.org

Diff Detail

Repository

rSPSITE puppet-swh-site

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vsellier created this revision.May 17 2022, 8:24 PM

Herald added a reviewer: System administrators. · View Herald TranscriptMay 17 2022, 8:24 PM

Harbormaster completed remote builds in B29441: Diff 28337.May 17 2022, 8:24 PM

vsellier requested review of this revision.May 17 2022, 8:24 PM

vsellier added a child revision: D7764: icinga checks: Activate the prometheus export on e2e tests.May 17 2022, 8:42 PM

ardumont added a subscriber: ardumont.May 18 2022, 2:31 PM

ardumont added inline comments.

site-modules/profile/manifests/icinga2/objects/e2e_checks_base.pp
8	I'm having a hard-time reading this, what does this mean? Add groups prometheus to user nagios?

vsellier added inline comments.May 18 2022, 2:35 PM

site-modules/profile/manifests/icinga2/objects/e2e_checks_base.pp
8	yep exactly I used this notation because when I try to configure the group via a user or a group class, puppet complains about duplicate declaration which makes sens.