Differential D7840

Refactor swh.lister.github.utils to swh.core.github.utils
ClosedPublic
Actions

Authored by ardumont on May 17 2022, 10:22 AM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T4232: Listers: Canonicalize listed github origins

Commits

rDCORE6fa229792d57: Refactor swh.lister.github.utils to swh.core.github.utils

Summary

This also:

extracts pytest fixtures needed to cover the GitHubSession code.
avoid mutating the inputted credentials passed in constructors
rework test docstrings to "it should" format for more concise description

Related to T4232

TODO in other diffs:

D7840: Move pytest fixtures into a runtime pytest module (to be reusable in swh.lister)
D7870: Branch the use of GitHubSession in the new function to compute the canonical github urls

Diff Detail

Repository

rDCORE Foundations and core functionalities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.May 17 2022, 10:22 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 17 2022, 10:22 AM

ardumont edited the summary of this revision. (Show Details)May 17 2022, 10:23 AM

Build is green

Patch application report for D7840 (id=28317)

Rebasing onto 60f384d35a...

Current branch diff-target is up to date.

Changes applied before test

commit 6fa229792d57cc0b445293ade8699d06074cd8b9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon May 16 16:59:04 2022 +0200

    Refactor swh.lister.github.utils to swh.core.github.utils
    
    This also:
    - extracts pytest fixtures needed to cover the GitHubSession code.
    - avoid mutating the inputted credentials passed in constructors
    - rework test docstrings to "it should" format for more concise description
    
    Related to T4232

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/412/ for more details.

Harbormaster completed remote builds in B29419: Diff 28317.May 17 2022, 10:24 AM

ardumont requested review of this revision.May 17 2022, 10:24 AM

ardumont mentioned this in T4232: Listers: Canonicalize listed github origins.May 17 2022, 10:27 AM