Differential D7827

Initialize the success boolean early to avoid unbound exception
ClosedPublic
Actions

Authored by ardumont on May 13 2022, 9:57 AM.

Details

Reviewers

vsellier

Group Reviewers

Reviewers

Maniphest Tasks

Restricted Maniphest Task

Commits

rDLDBASEf510a00d10b3: Initialize the success boolean early to avoid unbound exception

Summary

Related to T4236

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 29365
Build 45888: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 45887: arc lint + arc unit

Event Timeline

ardumont created this revision.May 13 2022, 9:57 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 13 2022, 9:57 AM

Build is green

Patch application report for D7827 (id=28259)

Rebasing onto a3a2b11473...

Current branch diff-target is up to date.

Changes applied before test

commit f510a00d10b3451161d3af756e415b9916d6d8fa
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri May 13 09:56:43 2022 +0200

    Initialize the success boolean early to avoid unbound exception
    
    Related to T4236

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/787/ for more details.

Harbormaster completed remote builds in B29365: Diff 28259.May 13 2022, 10:00 AM

ardumont requested review of this revision.May 13 2022, 10:00 AM

ardumont mentioned this in T4238: Deploy latest loaders version (> v3.4).May 13 2022, 10:17 AM

vsellier accepted this revision.May 13 2022, 10:19 AM

This revision is now accepted and ready to land.May 13 2022, 10:19 AM

Closed by commit rDLDBASEf510a00d10b3: Initialize the success boolean early to avoid unbound exception (authored by ardumont). · Explain WhyMay 13 2022, 10:22 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDBASEf510a00d10b3: Initialize the success boolean early to avoid unbound exception.

vlorentz added a reverting change: D7828: BaseLoader: Fix handling of exceptions derived directly from BaseException.May 13 2022, 11:08 AM